Bump keras version to 3.12 & remove run_eagerly=True in models with Discretization layer #734
+1
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takumiohym
requested review from
conchitagoogle,
kylesteckler,
olex-snk and
sanjanalreddy
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated keras version from 3.10 to 3.12, which includes many updates like the Discretization layer issue in graph mode. (see keras-team/keras#21468).
With this version, the temporary introduced argument
run_eagerly=Truein compilation can be removed from these notebooks, which leads to 5-10x faster training:I've confirmed this change won't introduce any underlying dependency change.