refactor: readdirplus test package migration [GKE-GCSFuse Test migration] #3891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PranjalC100
force-pushed
the
test-migration-readdirplus
branch
4 times, most recently
from
3d687a2 to
01e7e13
Compare
PranjalC100
force-pushed
the
test-migration-readdirplus
branch
from
01e7e13 to
017949d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3891 +/- ##
==========================================
- Coverage 82.42% 0 -82.43%
==========================================
Files 145 0 -145
Lines 22769 0 -22769
==========================================
- Hits 18768 0 -18768
+ Misses 3458 0 -3458
+ Partials 543 0 -543
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
undo changes in improved run e2e test changes
ashmeenkaur
reviewed
Oct 27, 2025
| testDirPath = setup.SetupTestDirectory(testDirName) | ||
| func mountGCSFuseAndSetupTestDir(flags []string, ctx context.Context, storageClient *storage.Client) { | ||
| setup.MountGCSFuseWithGivenMountWithConfigFunc(testEnv.cfg, flags, mountFunc) | ||
| setup.SetMntDir(testEnv.cfg.GCSFuseMountedDirectory) |
Collaborator
There was a problem hiding this comment.
This should be GCSFuse or GKE mounted directory based on how tests are running. Can you check if this is working in both cases?
Member
Author
There was a problem hiding this comment.
checked both are working!
tools/integration_tests/readdirplus/readdirplus_without_dentry_cache_test.go
Outdated
Show resolved
Hide resolved
PranjalC100
force-pushed
the
test-migration-readdirplus
branch
from
bb0a45b to
37bd524
Compare
PranjalC100
force-pushed
the
test-migration-readdirplus
branch
from
37bd524 to
8d34fc5
Compare
PranjalC100
force-pushed
the
test-migration-readdirplus
branch
from
98acaac to
30c0332
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes changes to migrate readdirplus test package to use common config file. This common config will be used by both GCSFuse binary and GCSFuse csi driver tests.
Changes include:
refactoring to use config file by test methods.
changes are made in a backward compatible way so tests can run with both config file and flags. This will be cleaned up in future PRs after the migration is complete.
Migration of readdirplus package so it can use config file.
Link to the issue in case of a bug fix.
b/445951883
Testing details
Any backward incompatible change? If so, please explain.