Skip to content

refactor: log rotation test package migration [GKE-GCSFuse Test migration] #3898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

refactor: log rotation test package migration [GKE-GCSFuse Test migration] #3898

wants to merge 12 commits into from

Conversation

@PranjalC100
Copy link
Member

@PranjalC100 PranjalC100 commented Oct 16, 2025 •
edited
Loading

Description

This PR includes changes to migrate log rotation test package to use common config file. This common config will be used by both GCSFuse binary and GCSFuse csi driver tests.

Changes include:

refactoring to use config file by test methods.
changes are made in a backward compatible way so tests can run with both config file and flags. This will be cleaned up in future PRs after the migration is complete.
Migration of log rotation package so it can use config file.

Link to the issue in case of a bug fix.

b/445952888

Testing details

  1. Manual - Manually tested with config file for both cases when mounted directory is set and not set. Also validated that the tests work without config file.
  2. Unit tests - NA
  3. Integration tests - via KOKORO

Any backward incompatible change? If so, please explain.

@PranjalC100 PranjalC100 requested review from a team and Tulsishah as code owners October 16, 2025 08:25
@PranjalC100 PranjalC100 requested a review from charith87 October 16, 2025 08:25
@github-actions github-actions bot added the remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. label Oct 16, 2025
@PranjalC100 PranjalC100 removed the request for review from charith87 October 16, 2025 08:25
@github-actions
Copy link

github-actions bot commented Oct 17, 2025

Hi @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

12 similar comments
@github-actions
Copy link

github-actions bot commented Oct 20, 2025

Hi @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 21, 2025

Hi @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 22, 2025

Hi @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Hi @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 24, 2025

Hi @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

Hi @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 28, 2025

Hi @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

Hi @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Hi @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 31, 2025

Hi @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Hi @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Hi @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@PranjalC100 PranjalC100 changed the title DNR log rotation refactor: log rotation test package migration [GKE-GCSFuse Test migration] Nov 5, 2025
@PranjalC100 PranjalC100 added the execute-integration-tests Run only integration tests label Nov 5, 2025
@PranjalC100 PranjalC100 force-pushed the test-migration-log-rotation branch from 87435b0 to ccca684 Compare November 5, 2025 03:30
@PranjalC100 PranjalC100 force-pushed the test-migration-log-rotation branch from ccca684 to da1f10a Compare November 5, 2025 06:56
@PranjalC100 PranjalC100 force-pushed the test-migration-log-rotation branch from da1f10a to 4f6a4a8 Compare November 5, 2025 07:07
PranjalC100
PranjalC100 commented Nov 5, 2025
View reviewed changes
ashmeenkaur
ashmeenkaur reviewed Nov 5, 2025
View reviewed changes
Copy link
Collaborator

@ashmeenkaur ashmeenkaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are backward incompatible as the script in run_test_mounted_directory.sh is failing.

gcsfuse/tools/integration_tests/run_tests_mounted_directory.sh

Line 333 in 6072d21

GODEBUG=asyncpreemptoff=1 go test ./tools/integration_tests/log_rotation/... -p 1 --integrationTest -v --mountedDirectory=$MOUNT_DIR ${ZONAL_BUCKET_ARG}

Something like below conditional log file update needs to be added until GKE tests fully migrate:

gcsfuse/tools/integration_tests/read_cache/setup_test.go

Line 97 in 6072d21

if setup.ConfigFile() == "" {

tools/integration_tests/test_config.yaml Outdated
log_rotation:
- mounted_directory: "${MOUNTED_DIR}"
test_bucket: "${BUCKET_NAME}"
log_file: /tmp/gcsfuse-tmp/LogRotationTest.log
Copy link
Collaborator

@ashmeenkaur ashmeenkaur Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer required. In fact we decided to clean up this flag from the config file.

Copy link
Member Author

@PranjalC100 PranjalC100 Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay will remove it, for now. Will clean this flag from the config files later in a separate PR. Wasn't using this log_file flag anywhere

@PranjalC100 PranjalC100 force-pushed the test-migration-log-rotation branch 3 times, most recently from da3529f to 2fe122a Compare November 6, 2025 11:59
@PranjalC100 PranjalC100 force-pushed the test-migration-log-rotation branch from 2fe122a to 6ca9fef Compare November 6, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tulsishah Tulsishah Awaiting requested review from Tulsishah Tulsishah is a code owner

@ashmeenkaur ashmeenkaur Awaiting requested review from ashmeenkaur

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

execute-integration-tests Run only integration tests remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PranjalC100 @ashmeenkaur