Skip to content

Feat 452559775: Capture enviornment information (mem, cpu, disk) during startup #3899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feat 452559775: Capture enviornment information (mem, cpu, disk) during startup #3899

wants to merge 4 commits into from

Conversation

@ameoghosh
Copy link
Contributor

@ameoghosh ameoghosh commented Oct 16, 2025

…ng mount

Please ensure your PR title follows the format:

feat(api): Capture enviornment information (mem, cpu, disk) during startup

Example:
feat(api): add user login endpoint

Available types:

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

Description

Background:
When running GCS fuse mount, customer use to provide actual memory in GB to use or disk size for caching etc.

Motivation:
Make customer like easy to configure %age of resource available than absolute value.

Acceptance Criteria:
Verify information is captured in logger.

Link to the issue in case of a bug fix.

Testing details

  1. Manual - Yes
  2. Unit tests - NA
  3. Integration tests - NA

Any backward incompatible change? If so, please explain.

@ameoghosh ameoghosh requested a review from a team as a code owner October 16, 2025 11:39
@github-actions github-actions bot added the remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. label Oct 16, 2025
@github-actions
Copy link

github-actions bot commented Oct 16, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Feat 452559775: Capture enviornment information (mem, cpu, disk) during startup". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@ameoghosh ameoghosh requested a review from charith87 October 16, 2025 11:39
@codecov
Copy link

codecov bot commented Oct 16, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 267 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.50%. Comparing base (3d9975c) to head (f028b6d).
⚠️ Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
internal/mgmt/GCSFuseMgmt.go 0.00% 76 Missing ⚠️
internal/mgmt/GCSFuseMgmtMem.go 0.00% 73 Missing ⚠️
internal/mgmt/GCSFuseMgmtCPU.go 0.00% 65 Missing ⚠️
internal/mgmt/GCSFuseMgmtEnv.go 0.00% 27 Missing ⚠️
internal/mgmt/GCSFuseMgmtDisk.go 0.00% 15 Missing ⚠️
cmd/legacy_main.go 0.00% 11 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3899      +/-   ##
==========================================
- Coverage   82.42%   81.50%   -0.92%     
==========================================
  Files         145      150       +5     
  Lines       22769    23017     +248     
==========================================
- Hits        18768    18761       -7     
- Misses       3458     3716     +258     
+ Partials      543      540       -3
Flag Coverage Δ
unittests 81.50% <0.00%> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Oct 20, 2025

Hi @vadlakondaswetha, @charith87, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

2 similar comments
@github-actions
Copy link

github-actions bot commented Oct 21, 2025

Hi @vadlakondaswetha, @charith87, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 22, 2025

Hi @vadlakondaswetha, @charith87, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 24, 2025

Hi @vadlakondaswetha, @charith87, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

2 similar comments
@github-actions
Copy link

github-actions bot commented Oct 27, 2025

Hi @vadlakondaswetha, @charith87, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 28, 2025

Hi @vadlakondaswetha, @charith87, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@charith87 charith87 removed their request for review October 28, 2025 09:05
@github-actions
Copy link

github-actions bot commented Oct 29, 2025

Hi @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

4 similar comments
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Hi @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 31, 2025

Hi @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Hi @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Hi @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@gargnitingoogle gargnitingoogle mentioned this pull request Nov 4, 2025
Draft
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Hi @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

2 similar comments
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Hi @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Hi @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vadlakondaswetha vadlakondaswetha Awaiting requested review from vadlakondaswetha vadlakondaswetha is a code owner automatically assigned from GoogleCloudPlatform/gcsfuse-codeowners

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ameoghosh