Bug 449182561: Handle SIGTERM irrespective of unmount status

[ameoghosh]

Please ensure your PR title follows the format:

type(scope): subject

Example:
feat(api): add user login endpoint

Available types:

• feat: A new feature
• fix: A bug fix
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
• refactor: A code change that neither fixes a bug nor adds a feature
• perf: A code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
• ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit

Description

When we are returning from the go routine for signal handler, instead of return we should os.Exit with background thread with sleep 30sec alongside unmount. so that unconditionally the process terminates and does not get stuck in the main thread (What is the suspicion for delay reproduced during internal tests go/gcsfuse-sigterm-handling).

Link to the issue in case of a bug fix.

Testing details

1. Manual - NA
2. Unit tests - NA
3. Integration tests - NA

Any backward incompatible change? If so, please explain.

[github-actions]

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Bug 449182561: Handle SIGTERM irrespective of unmount status". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

[ashmeenkaur]

/gemini review

[gemini-code-assist]

Code Review

The pull request introduces a watchdog timer to forcefully terminate the process if unmounting hangs upon receiving a SIGTERM or SIGINT signal. This is a good solution to prevent the process from getting stuck. My feedback focuses on improving the implementation of this watchdog by using a constant for the timeout, using a more appropriate exit code to signal an abnormal termination, and improving the clarity of the log messages. I've also noted that the use of os.Exit will bypass some graceful shutdown procedures, which is a trade-off to consider.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.68%. Comparing base (903dd41) to head (d917a0d).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
cmd/legacy_main.go	0.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3957      +/-   ##
==========================================
- Coverage   82.77%   82.68%   -0.10%     
==========================================
  Files         148      148              
  Lines       18030    18062      +32     
==========================================
+ Hits        14925    14934       +9     
- Misses       2551     2570      +19     
- Partials      554      558       +4     

Flag	Coverage Δ
unittests	82.68% <0.00%> (-0.10%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Hi @kislaykishore, @ashmeenkaur, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

[github-actions]

Hi @kislaykishore, @ashmeenkaur, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

[github-actions]

Hi @kislaykishore, @ashmeenkaur, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

[github-actions]

Hi @kislaykishore, @ashmeenkaur, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!