Skip to content

Conversation

@PranjalC100
Copy link
Member

Description

This PR includes changes to migrate inactive_stream_timeout test package to use common config file. This common config will be used by both GCSFuse binary and GCSFuse csi driver tests.

Changes include:

refactoring to use config file by test methods.
changes are made in a backward compatible way so tests can run with both config file and flags. This will be cleaned up in future PRs after the migration is complete.
Migration of inactive_stream_timeout package so it can use config file.

Link to the issue in case of a bug fix.

b/445952891

Testing details

  1. Manual - Manually tested with config file for both cases when mounted directory is set and not set. Also validated that the tests work without config file.
  2. Unit tests - NA
  3. Integration tests - via KOKORO

Any backward incompatible change? If so, please explain.

@PranjalC100 PranjalC100 requested review from a team and Tulsishah as code owners November 4, 2025 02:28
@github-actions github-actions bot added the remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. label Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Hi @ashmeenkaur, @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@PranjalC100 PranjalC100 force-pushed the test-migration-inactive-stream-timeout branch from 12cc9c2 to 90f1283 Compare November 5, 2025 13:37
@PranjalC100 PranjalC100 force-pushed the test-migration-inactive-stream-timeout branch from 90f1283 to c37b9a0 Compare November 5, 2025 13:52
@PranjalC100 PranjalC100 added the execute-integration-tests Run only integration tests label Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (f9d3f9d) to head (c37b9a0).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #3964       +/-   ##
==========================================
- Coverage   83.24%       0   -83.25%     
==========================================
  Files         148       0      -148     
  Lines       18057       0    -18057     
==========================================
- Hits        15031       0    -15031     
+ Misses       2485       0     -2485     
+ Partials      541       0      -541     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Hi @ashmeenkaur, @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execute-integration-tests Run only integration tests remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants