Skip to content

Conversation

@vipnydav
Copy link
Member

@vipnydav vipnydav commented Nov 7, 2025

Description

This PR updates the github.com/jacobsa/fuse dependency to commit d2942a9.

This update allows for both vectored and non-vectored reads to coexist, which provides more flexibility in how read operations are handled. Previously, the UseVectoredRead mount option determined the read buffer strategy. With this change, the FUSE library will always provide a destination buffer (ReadFileOp.Dst). File systems can then optionally provide their own data buffers (ReadFileOp.Data) to take advantage of vectored reads and avoid extra memory copies.

This simplifies the read implementation and removes the need for the now-legacy UseVectoredRead flag.

Link to the issue in case of a bug fix.

b/458664097

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

Any backward incompatible change? If so, please explain.

@vipnydav vipnydav requested a review from a team as a code owner November 7, 2025 14:03
@vipnydav vipnydav requested a review from raj-prince November 7, 2025 14:03
@github-actions github-actions bot added the remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. label Nov 7, 2025
@vipnydav vipnydav added the execute-integration-tests Run only integration tests label Nov 7, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.09%. Comparing base (0f5c69c) to head (a804330).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3989      +/-   ##
==========================================
- Coverage   83.13%   83.09%   -0.04%     
==========================================
  Files         148      148              
  Lines       18188    18187       -1     
==========================================
- Hits        15120    15112       -8     
- Misses       2518     2523       +5     
- Partials      550      552       +2     
Flag Coverage Δ
unittests 83.09% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vipnydav vipnydav added the execute-perf-test Execute performance test in PR label Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execute-integration-tests Run only integration tests execute-perf-test Execute performance test in PR remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants