refactor: Remove DataBuf from ReadResponse #3993
Open
+134
−112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
DataBuffield from theReadResponsestruct. This is because theDataBuffield is redundant, as the same slice is passed toReadAtmethods and written to, and the caller already has access to the modified slice. This change simplifies the code by removing the need for repeated assignments.Link to the issue in case of a bug fix.
b/458976462
Testing details
Any backward incompatible change? If so, please explain.