Skip to content

Conversation

@vipnydav
Copy link
Member

@vipnydav vipnydav commented Nov 8, 2025

Description

This PR removes the DataBuf field from the ReadResponse struct. This is because the DataBuf field is redundant, as the same slice is passed to ReadAt methods and written to, and the caller already has access to the modified slice. This change simplifies the code by removing the need for repeated assignments.

Link to the issue in case of a bug fix.

b/458976462

Testing details

  1. Manual - Done
  2. Unit tests - NA
  3. Integration tests - Automated

Any backward incompatible change? If so, please explain.

@vipnydav vipnydav requested a review from a team as a code owner November 8, 2025 19:21
@vipnydav vipnydav requested a review from charith87 November 8, 2025 19:21
@vipnydav vipnydav added the execute-integration-tests Run only integration tests label Nov 8, 2025
@github-actions github-actions bot added the remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. label Nov 8, 2025
@codecov
Copy link

codecov bot commented Nov 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.08%. Comparing base (3016128) to head (4298eaf).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3993      +/-   ##
==========================================
- Coverage   83.11%   83.08%   -0.03%     
==========================================
  Files         148      148              
  Lines       18187    18183       -4     
==========================================
- Hits        15116    15108       -8     
- Misses       2520     2523       +3     
- Partials      551      552       +1     
Flag Coverage Δ
unittests 83.08% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execute-integration-tests Run only integration tests remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants