-
Notifications
You must be signed in to change notification settings - Fork 102
feat: add repro test for gmp:matchstuck #1782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
da9c939 to
06a6f1d
Compare
bernot-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pintohutch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the general tests LGTM - though IMO we shouldn't merge this until we fix the issue.
I vote we move this to a draft PR until we have the fix ready and updated tests here.
Hm, what's wrong with merging this now with clear TODOs? The PR to add fix will be then smaller (: I plan to deliver fix next week. |
Signed-off-by: bwplotka <[email protected]>
7efabb6 to
07ceb64
Compare
Signed-off-by: bwplotka <[email protected]>
07ceb64 to
5c7cceb
Compare
This is a starting point for further regressions tests when we will implement fix.
Depends on: