Skip to content

Conversation

@bwplotka
Copy link
Collaborator

@bwplotka bwplotka commented Oct 13, 2025

This is a starting point for further regressions tests when we will implement fix.

Depends on:

  1. feat: enable e2e tests against GCM; updated docs #1756
  2. feat: refactor querying into generic helper func #1781

@bwplotka bwplotka force-pushed the bwplotka/gmpfilter-repro branch 7 times, most recently from da9c939 to 06a6f1d Compare October 14, 2025 13:04
@bwplotka bwplotka marked this pull request as ready for review October 14, 2025 13:29
Copy link
Collaborator

@bernot-dev bernot-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@pintohutch pintohutch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the general tests LGTM - though IMO we shouldn't merge this until we fix the issue.

I vote we move this to a draft PR until we have the fix ready and updated tests here.

@bwplotka
Copy link
Collaborator Author

bwplotka commented Nov 7, 2025

  • though IMO we shouldn't merge this until we fix the issue.

Hm, what's wrong with merging this now with clear TODOs? The PR to add fix will be then smaller (:

I plan to deliver fix next week.

@bwplotka bwplotka force-pushed the bwplotka/gmpfilter-repro branch from 7efabb6 to 07ceb64 Compare November 7, 2025 14:19
@bwplotka bwplotka changed the base branch from bwplotka/e2e-gcmcheck to main November 7, 2025 14:19
@bwplotka bwplotka closed this Nov 7, 2025
@bwplotka bwplotka reopened this Nov 7, 2025
Signed-off-by: bwplotka <[email protected]>
@bwplotka bwplotka force-pushed the bwplotka/gmpfilter-repro branch from 07ceb64 to 5c7cceb Compare November 7, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants