fix: update out of sync Prometheus image #1789
Conversation
hsmatulis
changed the title
hsmatulis
force-pushed
the
hsmatulis-patch-examples
branch
from
946ded5 to
46f589a
Compare
The prometheus image in the example directory should be kept in sync with the one used by the 0.17 branch Signed-off-by: Henrique Matulis <[email protected]>
hsmatulis
force-pushed
the
hsmatulis-patch-examples
branch
from
46f589a to
06f35ed
Compare
| relabel_configs: | ||
| - source_labels: [__meta_kubernetes_pod_label_app] | ||
| regex: prom-example | ||
| regex: prom-example.* |
There was a problem hiding this comment.
I don't think this is enough, actually... the "app" label doesn't seem to be set on the nilebox manifest: https://raw.githubusercontent.com/GoogleCloudPlatform/prometheus-engine/main/examples/example-app.yaml
So this matches nothing.
IME this needs to be set to __meta_kubernetes_pod_name, and you need the regex because k8s adds random characters after prom-example
Or we update the manifest to set the app label
| - linux | ||
| initContainers: | ||
| - name: config-init | ||
| image: gke.gcr.io/gke-distroless/bash:gke_distroless_20240607.00_p0 |
| - name: prometheus-db | ||
| mountPath: /prometheus/data | ||
| - name: config-reloader | ||
| image: gke.gcr.io/prometheus-engine/config-reloader:v0.12.0-gke.5 |
There was a problem hiding this comment.
this is ideally bumped too, as mentioned in https://github.com/GoogleCloudPlatform/prometheus-engine/pull/1786/files#r2461450478
There was a problem hiding this comment.
Can we quickly hook it with /charts while we are here?
There was a problem hiding this comment.
Thanks, added some comments. Also not sure if docs should link to unreleased 0.17 branch/release at the moment or should we just use main. Let's chat
Also please update commit msg, that's why conform is complaining.
FYI, have you seen #1786?
Nevertheless let's converge to something that will work for docs. I'd say .6 image with config-reloader bump and doing this on 0.15 release might be best for now (let's discuss in gchat), but I wonder if there's a room for special branch for docs or at least minimal templating for basics like config-reloader version.
| containers: | ||
| - name: prometheus | ||
| image: gke.gcr.io/prometheus-engine/prometheus:v2.45.3-gmp.7-gke.0 | ||
| image: gke.gcr.io/prometheus-engine/prometheus:v2.53.5-gmp.0-gke.8 |
There was a problem hiding this comment.
So the issue, as mentioned in our docs, is the unfortunate cycle: Our repos is the source for building but also contain examples and outputs to use ONCE things are built and deployed. This image does not exists until we release things to GKE. Louhi flow only builds to staging. This is a major pain, but there's not much we can do, unless we want to show staging here OR some automation for creating PRs once we have GKE prod images.
There was a problem hiding this comment.
Looking on prod registry, I see .6 which is probably the best we can share now.
| image: gke.gcr.io/prometheus-engine/prometheus:v2.53.5-gmp.0-gke.8 | |
| image: gke.gcr.io/prometheus-engine/prometheus:v2.53.5-gmp.0-gke.6 |
The prometheus image in the example directory should be kept in sync with the one used by the 0.17 branch