Skip to content

Conversation

@olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Jul 24, 2025

This PR repairs rack-mini-profiler's patch to ActiveRecord, adding support for keyword arguments, too.

Details

Before Ruby 2.7, *args, &blk would mean "all args", but with the advent of real keyword arguments, this change is needed.

Inspired by the newrelic solution to the same problem.

This change follows the newrelic inspiration that the original of this file was linking to.
@olleolleolle olleolleolle force-pushed the ar-patch-with-kwargs branch from 01856b7 to e0891d1 Compare July 24, 2025 09:36
@olleolleolle olleolleolle changed the title ActiveRecord db patch: support kwargs fix: ActiveRecord db patch: support kwargs Jul 24, 2025
@nateberkopec nateberkopec merged commit bb1d257 into MiniProfiler:master Jul 24, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants