PhpStan: fix wrong params for trim
#5072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Sales
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes PHPStan type errors by adding explicit type casts and correcting function arguments. The changes address issues where functions expected string parameters but received other types (float or int).
Key changes:
- Added explicit string casts to
trim()calls inCreditmemo.phpto handle float inputs - Corrected
rtrim()second parameter from int0to string'0'inMatrix.php - Fixed incorrect array access pattern using
$valueinstead of$oldCurrencies[$key]inMatrix.php - Added missing
@throwsdocumentation tags for exceptions - Removed resolved PHPStan baseline entries
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/code/core/Mage/Sales/Model/Order/Creditmemo.php | Added string casts for trim() calls and @throws documentation tags |
| app/code/core/Mage/Adminhtml/Block/System/Currency/Rate/Matrix.php | Fixed rtrim() argument type and corrected array access logic |
| .phpstan.dist.baseline.neon | Removed PHPStan baseline entries for fixed type errors |
Contributor
Author
|
Safe to merge. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.