-
Notifications
You must be signed in to change notification settings - Fork 888
tempfix: pin setuptools #3795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
tempfix: pin setuptools #3795
Conversation
|
I'm sorry for not seeing that. I thought about offering a backport , but figured I'd address this first. Why don't you pull my changelog onto both of your PRs (or at least the backport) ? We can leave this open so it's at the top of the list so it keeps visibility until yours are merged (or another solution happens?) |
|
No worries, I'll just close my PR and we can keep the better+fresher one. I'll add a changelog to my backport and keep it open though, it'd be nice to keep Pyramid 1 working OotB as long as possible. I still have a couple projects using it. |
|
I still have some legacy stuff running on pyramid1 too, but I think it's mostly unported py27 so unaffected by all this. |
|
Hey all! Thanks for looking into this. As stated, we're just shy of a month away from this deprecation, and I was wondering if a release with this change will be available before then. Otherwise we will have to pin some libraries ourselves, which is also not a big deal, but having Pyramid handle this itself would be nice. |
|
You should pin your dependencies.... With respect to removing pkg_resources you can catch up on #3731. |
That is standard practice. Pinning a dependency's dependencies (i.e. pyramid's dependencies) is not. We're about 3 weeks out from this potentially breaking CI and installs. @luhn My contingency plan right now is to switch to our forks (my v2, your v1). I did a test, and I can entirely automate the switchover for all our affected code - and revert it as well. Introducing a setuptools requirement is too messy, as the package might already require it for something else. |
|
This should really resolve the issue: #3783 |
We are under 60 days from the planned removal of pkg_resources. I worry about the impact of this on CI and Automatic Deployments.
I suggest releasing a tempfix to pin setuptools, which will ensure anyone who has not independently pinned setuptools within their projects is not affected by this, as work continues on #3731 .