Skip to content

Test the logo_url to be not malformed #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Test the logo_url to be not malformed #928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions tests/test_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,8 +564,21 @@ def test_artifacthub_urls(container: ContainerData) -> None:
# for devel projects we pass it as a query
assert readme_url.path.endswith(".md")
assert "/README" in readme_url.path
assert "//" not in readme_url.path and "//" not in readme_url.path
# TODO(dmllr): add testing for logo-url
assert "//" not in readme_url.path

if "io.artifacthub.package.logo-url" in labels:
logo_url = urllib.parse.urlparse(
labels["io.artifacthub.package.logo-url"]
)
assert logo_url.scheme == "https"
assert logo_url.port is None
assert logo_url.netloc in (
"raw.githubusercontent.com",
"opensource.suse.com",
"gcc.gnu.org",
"spack.io",
)
assert "//" not in logo_url.path


@pytest.mark.parametrize(
Expand Down
Loading