Add support for handling system profiles #1388
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define two new tables:
* profiles
This table stores the complete profiles that have been provided
by clients as part of the system registration (announce_system)
or keepalive (update) request handling, which consists of three
fields, product_type, identifier and data.
* system_profiles
This table is used to link systems records to their associated
profiles in a one to many relationship, allowing for the same
profile records to be shared between multiple systems
Add support for handling any provided profiles to the handlers for
the announce_system and update requests in the connect V3 API.
This support involves checking that the provided profiles are valid
and, when provided for the first time, complete, with new profiles
being added to the profiles table, and appropriate references being
added or updated via the system_profiles table to associate systems
with their corresponding profiles.
Similarly, when incomplete profiles are included in update requests,
the corresponding complete profiles will be retrieved and used, with
any missing profiles being dropped and considered problematic.
Additionally, when problematic profiles are detected, whether invalid
or incomplete, they will be ignored and the X-System-Profiles-Action
header will be included in the response, with a value of clear-cache.
In the System model a new custom attribute, complete_profiles, with
an accompanying assignment method, complete_profiles=, is used to
handle the assignment of complete profiles to be associated with a
system record as part of record creation or update.
If racing requests attempt to create the same new profile, one will
succeed and the others will rescue the ActiveRecord:RecordNotUnique
exception and instead lookup the newly created profile record.
Update the test cases to validate correct operation of new models,
and associated request handling changes.
rtamalin
requested review from
brett060102,
digitaltom,
felixsch,
gbuenodevsuse,
mssola and
paragjain0910
Collaborator
Author
|
FYI while doing some heavy stress testing I'm seeing some DB stall issues |
Collaborator
Author
|
Investigating and the issue may be related to recent changes on the master branch |
Collaborator
Author
|
Yup having reverted my test env to be based upon current master branch I still see the same issue... Digging further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define two new tables:
Add support for handling any provided profiles to the handlers for the announce_system and update requests in the connect V3 API.
This support involves checking that the provided profiles are valid and, when provided for the first time, complete, with new profiles being added to the profiles table, and appropriate references being added or updated via the system_profiles table to associate systems with their corresponding profiles.
Similarly, when incomplete profiles are included in update requests, the corresponding complete profiles will be retrieved and used, with any missing profiles being dropped and considered problematic.
Additionally, when problematic profiles are detected, whether invalid or incomplete, they will be ignored and the X-System-Profiles-Action header will be included in the response, with a value of clear-cache.
In the System model a new custom attribute, complete_profiles, with an accompanying assignment method, complete_profiles=, is used to handle the assignment of complete profiles to be associated with a system record as part of record creation or update.
If racing requests attempt to create the same new profile, one will succeed and the others will rescue the ActiveRecord:RecordNotUnique exception and instead lookup the newly created profile record.
Update the test cases to validate correct operation of new models, and associated request handling changes.
Related Jira: TEL-265