-
Notifications
You must be signed in to change notification settings - Fork 0
[CVW-048] LocalizedString획득 아키텍처 리팩토링 #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the architecture for acquiring localized strings by replacing the previous singleton pattern with a dependency injection structure. Key changes include the removal of the legacy LocalizableText view, updating dependency registrations to include a new LocalizedStrProvider, and modifying various view models and builders to use the injected provider for localized string retrieval.
Reviewed Changes
Copilot reviewed 45 out of 45 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Projects/Features/Setting/Feature/Sources/View/LocalizableText.swift | Removal of legacy view using singleton-based localization. |
| Projects/Features/Setting/Feature/Sources/SettingBuilder.swift | Updated dependency injection to supply localized string provider. |
| Projects/Features/Setting/Example/Sources/DI/Assemblies.swift | Added DI registration for LocalizedStrProvider. |
| Projects/Features/Root/Feature/Sources/TabBar/* | Refactored tab bar components to use injected localized string provider and updated enum cases. |
| Projects/Features/Root/Feature/Sources/RootViewModel.swift | Switched to injected localized string provider for splash screen text generation. |
| Projects/Features/CoinDetail/Feature/Sources/CoinDetailPageViewModel.swift | Updated localized string retrieval to use dependency injection (note potential misspelling in key). |
| Projects/Features/AllMarketTicker/* | Refactored market ticker view models and builders to utilize LocalizedStrProvider. |
Comments suppressed due to low confidence (1)
Projects/Features/Setting/Feature/Sources/View/LocalizableText.swift:1
- Ensure that the removal of LocalizableText.swift is intentional and that its functionality has been fully migrated to the new architecture without leaving any dangling dependencies.
Entire file removed
변경된 점
LocalizedString획득 아키텍처 리팩토링
키값의 경우
enum계층을 사용하여 사용성 및 가시성을 높였습니다.