[STORY-1890] Add support for limited collaborators #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurelien-reeves-scalingo
requested review from
leo-scalingo
and removed request for
EtienneM
leo-scalingo
requested changes
Apr 29, 2025
|
|
||
| type CollaboratorsService interface { | ||
| CollaboratorsList(ctx context.Context, app string) ([]Collaborator, error) | ||
| CollaboratorAdd(ctx context.Context, app string, email string) (Collaborator, error) |
Member
There was a problem hiding this comment.
To prevent breaking the API in the future for other params, can you use the signature:
CollaboratorAdd(ctx context.Context, app string, params CollaboratorAddParams) (Collaborator, error)
And have
type CollaboratorAddParams struct {
Email string `json:"email"`
IsLimited bool `json:"is_limited"`
}
And use this in the `SubresourceAdd` call
Contributor
Author
There was a problem hiding this comment.
done
aurelien-reeves-scalingo
deleted the
feat/story-1890/add-support-for-limited-collaborators
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.