Add rules for collection expressions #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@JimBobSquarePants Here are the requested upstream changes |
There was a problem hiding this comment.
Pull Request Overview
This PR adds new style rules to enforce the use of C# 12 collection expressions.
- Introduces a “Collection preferences” section in the editorconfig
- Enables
dotnet_style_prefer_collection_expressionat error severity - Enables ReSharper highlighting for collection expressions at error severity
| csharp_style_prefer_primary_constructors = false:none | ||
| # Collection preferences | ||
| dotnet_style_prefer_collection_expression = true:error | ||
| resharper_use_collection_expression_highlighting =true:error |
There was a problem hiding this comment.
[nitpick] Add a space after the '=' to match the formatting of the adjacent dotnet_style_prefer_collection_expression entry and improve readability.
Suggested change
| resharper_use_collection_expression_highlighting =true:error | |
| resharper_use_collection_expression_highlighting = true:error |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==================================
Coverage 19% 19%
==================================
Files 4 4
Lines 346 346
Branches 85 85
==================================
Hits 68 68
Misses 278 278
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.