Skip to content

Conversation

@NemoDacremont
Copy link
Contributor

Enables getting the PVE version using proxmox-api-go version

closes #508

@Tinyblargon
Copy link
Collaborator

@NemoDacremont Thank you for this addition.
Might be better if we return the version as a string like "9.0.10" instead of json.
There already is a Version.String().

@Tinyblargon Tinyblargon added type/feature Completely new functionality. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files test/done This PR has been tested and the result was succesfull labels Nov 2, 2025
@NemoDacremont
Copy link
Contributor Author

@Tinyblargon done 👍 I'm never sure in these cases if I should print the JSON or the string version

@Tinyblargon Tinyblargon merged commit 4548f91 into Telmate:master Nov 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files test/done This PR has been tested and the result was succesfull type/feature Completely new functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

migrate: getVersion to version

2 participants