Skip to content

Conversation

@Sounak008
Copy link
Contributor

Because

Moving club_40_gifs.json into points folder.

This PR

  • The club 40 gifs JSON file is moved to bot-commands/points/
  • The club 40 gifs file is renamed with kebab case i.e. club-40-gifs.json
  • bot-commands/club-40/ is deleted
  • Relevant imports fixed after relocation:
    i. In bot-commands/points/award-points.js:3
    ii. In bot-commands/points/points.test.js:25

Issue

Closes #696

Additional Information

I got confused between kebab case and snake case names so a commit name is messed up. I mentioned it in the commit just after that. This is exactly why some steps are re-done. Sorry!

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Callbacks command: Update verbiage
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If this PR adds new features or functionality, I have added new tests
  • If applicable, I have ensured all tests related to any command files included in this PR pass, and/or all snapshots are up to date

Copy link
Contributor

@mao-sz mao-sz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The club40 directory still needs deleting now that the file has been moved to the right place. You've copied the file over but the old stuff is still there

@Sounak008
Copy link
Contributor Author

The club40 directory still needs deleting now that the file has been moved to the right place. You've copied the file over but the old stuff is still there

Oh! I did delete the directory...Maybe it got added back again somehow...I will fix it ASAP.

@Sounak008
Copy link
Contributor Author

Okay, it's fixed now..I committed from the points directory last time 🤦 @MaoShizhong

@JustWaveThings JustWaveThings self-requested a review March 28, 2025 20:46
Copy link
Contributor

@JustWaveThings JustWaveThings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @Sounak008! Thanks for doing this! 🚀

@JustWaveThings JustWaveThings merged commit c467f07 into TheOdinProject:main Mar 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chore: Move club_40_gifs.json into points folder

3 participants