-
-
Notifications
You must be signed in to change notification settings - Fork 31
Made Notification badge count dynamic #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for adoptium-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank for raising this, my only concern here is that if you refresh the page the count returns to the original number. My thoughts are, keep this logic in place but only show notifications if they're from the last week. What do you think? |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
- Coverage 70.98% 70.79% -0.20%
==========================================
Files 200 200
Lines 14029 14071 +42
Branches 1069 1069
==========================================
+ Hits 9959 9961 +2
- Misses 4053 4093 +40
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ohhhh okay thats a good idea. Let me adjust to that |
74a80ef to
95df697
Compare
Description of change
This pull request addresses the issue where the notification badge was displaying a fixed value of 1. The badge now dynamically shows the total number of announcements. Additionally, when a user views an announcement, the notification count decreases.
Screencast from 2025-08-11 19-01-48.webm
closes #96
Checklist
npm testandnpm run buildpasses