-
-
Notifications
You must be signed in to change notification settings - Fork 31
[issue-104] Move block help promote #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[issue-104] Move block help promote #422
Conversation
✅ Deploy Preview for adoptium-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
==========================================
- Coverage 73.93% 73.92% -0.01%
==========================================
Files 177 176 -1
Lines 3346 3341 -5
Branches 1022 1022
==========================================
- Hits 2474 2470 -4
Misses 742 742
+ Partials 130 129 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tellison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good, but I would like to reword the sections about "defining the future of Java" - which is marketing speak that is open to misinformation.
Currently not in a position to offer a suggestion, but will do so tomorrow.
src/app/[locale]/join-us/__tests__/__snapshots__/page.test.tsx.snap
Outdated
Show resolved
Hide resolved
src/app/[locale]/join-us/__tests__/__snapshots__/page.test.tsx.snap
Outdated
Show resolved
Hide resolved
|
@CarmenDelgadoEclipse can you check the Tim's comment above? |
tellison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some specific suggestions. The theme is to ensure that we do not claim to speak for all Java, but that our supporters can help influence and evolve Adoptium projects.
src/app/[locale]/join-us/__tests__/__snapshots__/page.test.tsx.snap
Outdated
Show resolved
Hide resolved
src/app/[locale]/join-us/__tests__/__snapshots__/page.test.tsx.snap
Outdated
Show resolved
Hide resolved
src/app/[locale]/join-us/__tests__/__snapshots__/page.test.tsx.snap
Outdated
Show resolved
Hide resolved
|
Thank you @tellison for your feebacks, before validated or not, I would like Carmen to give her opinion. 🙏 |
|
Thank you, @tellison, these updates will make a big difference! @xavierfacq +1 to everything Tim's suggested! |
….snap Co-authored-by: Tim Ellison <[email protected]>
….snap Co-authored-by: Tim Ellison <[email protected]>
Co-authored-by: Tim Ellison <[email protected]>
Co-authored-by: Tim Ellison <[email protected]>
Co-authored-by: Tim Ellison <[email protected]>
Co-authored-by: Tim Ellison <[email protected]>
Co-authored-by: Tim Ellison <[email protected]>
….snap Co-authored-by: Tim Ellison <[email protected]>
|
@tellison I have reported all your suggestions, fixed the last problee with the tests. Everything seems to be ready to go live! |
| class="self-stretch text-center text-white text-[56px] lg:text-[80px] leading-[114.286%] md:leading-[120%] font-semibold" | ||
| > | ||
| What we’re trying to achieve | ||
| Join us in ensuring the future of open source Java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this phrasing is appropriate. OpenJDK upstream is OSS (and always will be), I think we want to say something like "Join us in ensuring the future of world-class, open, enterprise-ready Java runtimes"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this phrase requires some rethinking, as the implications just feel wrong. It is subtle, but there is good value in the Temurin project that we don't need to be writing anything that is open to misinterpretation or confusion.
| class="text-4xl leading-[122%] md:text-5xl md:[116%] text-white font-semibold" | ||
| > | ||
| Ways to support us | ||
| Power the evolution of our open Java runtimes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tellison Do we need to be careful about (Tm) here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I think we are on the correct side of (tm)-usage, but the change of title seems a little unnecessarily marketing-speak with the potential for causing subtle confusion. I say we just steer away from such phrases as 'evolving/defining/changing' the future of Java. That's not the goal of this project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, not sure to understand, do we have to change or rollback something then?
| class="self-stretch text-center text-white text-[56px] lg:text-[80px] leading-[114.286%] md:leading-[120%] font-semibold" | ||
| > | ||
| What we’re trying to achieve | ||
| Join us in ensuring the future of open source Java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this phrase requires some rethinking, as the implications just feel wrong. It is subtle, but there is good value in the Temurin project that we don't need to be writing anything that is open to misinterpretation or confusion.
| class="text-4xl leading-[122%] md:text-5xl md:[116%] text-white font-semibold" | ||
| > | ||
| Ways to support us | ||
| Power the evolution of our open Java runtimes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I think we are on the correct side of (tm)-usage, but the change of title seems a little unnecessarily marketing-speak with the potential for causing subtle confusion. I say we just steer away from such phrases as 'evolving/defining/changing' the future of Java. That's not the goal of this project.
Description of change
Implement modifications from issues:
#104 and#90Please read carefully expected behaviors.
Check here: https://deploy-preview-422--adoptium-next.netlify.app/
Checklist
npm testandnpm run buildpasses