-
Notifications
You must be signed in to change notification settings - Fork 680
docs: fix the path reference for nixl docs #4194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Tushar Sharma <[email protected]>
WalkthroughUpdated relative path redirects in Sphinx documentation configuration for Nixl Connect API pages. Changed redirect targets from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Tushar Sharma <[email protected]>
Signed-off-by: Tushar Sharma <[email protected]>
This reverts commit 4e6ab51.
This reverts commit f2223f0.
This reverts commit 24d8887.
Signed-off-by: Tushar Sharma <[email protected]>
Signed-off-by: Tushar Sharma <[email protected]>
Overview:
NIXL paths were not properly getting redirected due to the path. sphinx-reredirects interprets the relative path from the directory containing the source file, not from the file itself.
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit