fix(superset-frontend): Fixes for broken functionality when an application root is defined #36058

martyngigg · 2025-11-10T17:19:35Z

SUMMARY

Fixes for the settings menu:

includes app root in the link to the user information
removes old superset/fab_overrides template references. The templates were removed in chore: clean up more flask/jinja html views #34093.
fixes 'Create chart' button on SQL lab interface in the presence of a non-empty application root

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Fixes #35027

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

The superset/fab_override templates no longer exist but were still referenced. Remove the override classes that reference them and fallback to the FAB templates.

The ReactRouter has basePath set to applicationRoot, therefore all paths must be relative to this

bito-code-review · 2025-11-10T17:19:45Z

Bito Review Skipped - Source Branch Not Found

Bito didn’t review this change because the pull request is no longer valid. It may have been merged, or the source/target branch may no longer exist.

korbit-ai

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Empty applicationRoot causes incorrect path stripping ▹ view
	Uncached stripAppRoot call on navigation ▹ view

Files scanned

File Path	Reviewed
superset-frontend/src/utils/pathUtils.ts	✅
superset-frontend/src/utils/assetUrl.ts	✅
superset-frontend/src/features/home/Menu.tsx	✅
superset-frontend/src/features/home/RightMenu.tsx	✅
superset-frontend/src/SqlLab/components/ResultSet/index.tsx	✅
superset/views/base.py	✅
superset/security/manager.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

superset-frontend/src/utils/pathUtils.ts

superset-frontend/src/SqlLab/components/ResultSet/index.tsx

codecov · 2025-11-10T18:00:50Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.70%. Comparing base (c42e3c6) to head (97a5ade).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #36058       +/-   ##
===========================================
+ Coverage        0   68.70%   +68.70%     
===========================================
  Files           0      622      +622     
  Lines           0    45743    +45743     
  Branches        0     4979     +4979     
===========================================
+ Hits            0    31427    +31427     
- Misses          0    13070    +13070     
- Partials        0     1246     +1246

Flag	Coverage Δ
hive	`44.15% <ø> (?)`
mysql	`67.78% <ø> (?)`
postgres	`67.83% <ø> (?)`
presto	`47.71% <ø> (?)`
python	`68.67% <ø> (?)`
sqlite	`67.44% <ø> (?)`
unit	`100.00% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull Request Overview

This PR fixes broken functionality when an application root is defined in Superset's configuration by ensuring proper handling of URL paths throughout the frontend and cleaning up obsolete backend template code.

Adds ensureStaticPrefix utility to conditionally apply static asset prefixes to relative paths
Fixes "Create chart" button in SQL Lab to correctly handle app roots when opening in new windows vs navigating in-app
Removes obsolete FAB template widget classes from backend that were orphaned by a previous PR

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
superset/views/base.py	Removes unused `SupersetListWidget` class and `ListWidget` import
superset/security/manager.py	Removes unused widget classes (`SupersetSecurityListWidget`, `SupersetRoleListWidget`) and their assignments
superset-frontend/src/utils/assetUrl.ts	Adds `ensureStaticPrefix` function to handle static asset URLs
superset-frontend/src/utils/assetUrl.test.ts	Adds tests for `assetUrl` and `ensureStaticPrefix` functions
superset-frontend/src/features/home/RightMenu.tsx	Applies `ensureAppRoot` to user info URL
superset-frontend/src/features/home/Menu.tsx	Applies `ensureStaticPrefix` to brand images and `ensureAppRoot` to brand links
superset-frontend/src/features/home/Menu.test.tsx	Updates test to verify brand image URLs include static assets prefix
superset-frontend/src/explore/exploreUtils/index.js	Adds `includeAppRoot` parameter to `getURIDirectory` and `mountExploreUrl` functions
superset-frontend/src/SqlLab/components/ResultSet/index.tsx	Uses `includeAppRoot` parameter to correctly handle URLs for new window vs in-app navigation

Copilot · 2025-11-12T18:27:48Z

superset-frontend/src/utils/assetUrl.test.ts

+    expect(assetUrl(absoluteResourcePath)).toBe(
+      `${app_root}/${absoluteResourcePath}`,
+    );


The test for assetUrl with an absolute URL (line 38-40) expects it to prepend the app root and a slash, which would produce invalid URLs like /myapp/https://cdn.domain.com/static/endpoint/img.png. The assetUrl function is designed for relative paths only. This test case should either be removed or moved to a separate test that validates assetUrl should not be used with absolute URLs.

Suggested change

expect(assetUrl(absoluteResourcePath)).toBe(

`${app_root}/${absoluteResourcePath}`,

);

Copilot · 2025-11-12T18:27:49Z

superset-frontend/src/utils/assetUrl.test.ts

+const absoluteResourcePath = `https://cdn.domain.com/static${resourcePath}`;
+
+beforeEach(() => {
+  // Clear app root


The comment says "Clear app root" but the code is actually clearing the static assets prefix mock. The comment should be updated to "Clear static assets prefix" to accurately reflect what the code is doing.

Suggested change

// Clear app root

// Clear static assets prefix

Copilot · 2025-11-12T18:27:49Z

superset-frontend/src/features/home/Menu.test.tsx

 beforeEach(() => {
  // setup a DOM element as a render target
  useSelectorMock.mockClear();
+  // By default use empty app root


The comment says "By default use empty app root" but the code is actually setting the static assets prefix mock to an empty string. The comment should be updated to "By default use empty static assets prefix" to accurately reflect what the code is doing.

Suggested change

// By default use empty app root

// By default use empty static assets prefix

martyngigg added 4 commits November 10, 2025 12:02

Ensure User Info link in RightMenu contains app root

652c52b

Remove old fab_override template references

56b136d

The superset/fab_override templates no longer exist but were still referenced. Remove the override classes that reference them and fallback to the FAB templates.

Fix brand logo src and href to include app root

7c9ed21

Fix create chart from SQL lab.

0e3f867

The ReactRouter has basePath set to applicationRoot, therefore all paths must be relative to this

pull-request-size bot added the size/L label Nov 10, 2025

dosubot bot added the change:frontend Requires changing the frontend label Nov 10, 2025

This was referenced Nov 10, 2025

fix(menu): Use app prefix in Menu brand icon url #34935

Closed

Invalid UI URL's with SUPERSET_APP_ROOT #35027

Open

korbit-ai bot suggested changes Nov 10, 2025

View reviewed changes

superset-frontend/src/utils/pathUtils.ts Outdated Show resolved Hide resolved

superset-frontend/src/SqlLab/components/ResultSet/index.tsx Outdated Show resolved Hide resolved

martyngigg force-pushed the non-empty-app-root-fixes branch 2 times, most recently from 2f699f6 to 09fa854 Compare November 11, 2025 11:29

Add option to include app root rather than stripping it afterwards

97a5ade

martyngigg force-pushed the non-empty-app-root-fixes branch from 09fa854 to 97a5ade Compare November 11, 2025 12:25

marcelomarkus approved these changes Nov 11, 2025

View reviewed changes

sadpandajoe requested review from Copilot, geido and sadpandajoe November 12, 2025 18:23

Copilot AI reviewed Nov 12, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(superset-frontend): Fixes for broken functionality when an application root is defined #36058

fix(superset-frontend): Fixes for broken functionality when an application root is defined #36058

martyngigg commented Nov 10, 2025

Uh oh!

bito-code-review bot commented Nov 10, 2025 •

edited

Loading

Uh oh!

korbit-ai bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Nov 10, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 12, 2025

Uh oh!

Copilot AI Nov 12, 2025

Uh oh!

Copilot AI Nov 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	expect(assetUrl(absoluteResourcePath)).toBe(
	`${app_root}/${absoluteResourcePath}`,
	);

	// By default use empty app root
	// By default use empty static assets prefix

fix(superset-frontend): Fixes for broken functionality when an application root is defined #36058

Are you sure you want to change the base?

fix(superset-frontend): Fixes for broken functionality when an application root is defined #36058

Conversation

martyngigg commented Nov 10, 2025

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

bito-code-review bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

korbit-ai bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bito-code-review bot commented Nov 10, 2025 •

edited

Loading

korbit-ai bot left a comment •

edited

Loading

codecov bot commented Nov 10, 2025 •

edited

Loading