-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
rockchip: add 9tripod x3568 v4 support #8823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @rbqvq! 👋Thanks for submitting your first pull request to the Armbian project — we're excited to have you contributing! 🧡 If you'd like to stay informed about project updates or collaborate more closely with the team, Also, don’t forget to ⭐ star the repo if you haven’t already — and welcome aboard! 🚀 |
WalkthroughThis PR adds a new board configuration file for the 9Tripod X3568 v4 (RK3568-based board). It includes board metadata and partitioning information, configures mainline U-Boot sources with specific defconfig, branch, and patch directory mappings, and defines U-Boot blob placement logic. Additionally, it introduces persistent network interface renaming rules via udev for eth0/eth1 based on PCI/ethernet identifiers, and configures LED behavior for ethernet interfaces to reflect link states and activity. Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (9)
📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (18)📓 Common learnings📚 Learning: 2025-11-02T20:49:56.719ZApplied to files:
📚 Learning: 2025-10-26T10:41:35.118ZApplied to files:
📚 Learning: 2025-09-18T03:36:17.862ZApplied to files:
📚 Learning: 2025-09-14T06:32:29.806ZApplied to files:
📚 Learning: 2025-09-18T03:36:17.862ZApplied to files:
📚 Learning: 2025-07-17T04:12:33.125ZApplied to files:
📚 Learning: 2025-10-05T19:31:16.930ZApplied to files:
📚 Learning: 2025-07-25T03:51:50.830ZApplied to files:
📚 Learning: 2025-09-14T06:29:18.958ZApplied to files:
📚 Learning: 2025-09-07T17:39:32.272ZApplied to files:
📚 Learning: 2025-06-25T03:40:52.109ZApplied to files:
📚 Learning: 2025-09-14T06:10:25.610ZApplied to files:
📚 Learning: 2025-10-14T05:08:11.785ZApplied to files:
📚 Learning: 2025-06-12T21:03:39.686ZApplied to files:
📚 Learning: 2025-06-25T03:42:09.086ZApplied to files:
📚 Learning: 2025-07-23T07:30:52.265ZApplied to files:
📚 Learning: 2025-09-12T21:44:09.061ZApplied to files:
🔇 Additional comments (4)
Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
I would propose to drop version number from board config name (and board name) as it is unlikely to ever have other version. Usually and evenutally all versions are gettion supported or, like in some cases, only some. |
|
Different boards have different DeviceTree :( It's probably like this. They are in Taobao (China's e-commerce platform) sells X3568 v2. So I want to be consistent with what the main line submitted. |
Ordinary mess :(
OK, follow as planned. |
b3b386b to
1d3ce4c
Compare
|
/lgtm It is quite normal for different boards to have variations in hardware and versions. Once everything is finalized, this PR can be merged. |
|
✅ This PR has been reviewed and approved — all set for merge! |
|
I think all things are done. Kernel is still upstreaming. |
igorpecovnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it boots and worked fine.
Great!
Code looks good too. Tnx.
|
✅ This PR has been reviewed and approved — all set for merge! |
Description
Add support for the 9tripod x3568 v4 support
How Has This Been Tested?
I have built current and edge image based on trixie for the board locally, it boots and worked fine.
Checklist:
Notes:
Linux mainline upstreaming...
U-Boot upstreaming pending