-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
rockchip: Add CSC board Luckfox Lyra Plus + adjust RK3506 BOOT_SOC #8841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis PR adds support for the Luckfox Lyra Plus (Rockchip RK3506G2) by introducing a new board configuration file ( Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
config/bootenv/rk3506.txt (1)
3-3: Consider adding a trailing newline.The file is missing a trailing newline, which is a minor POSIX compliance and style issue. This is optional but helps with text file handling.
Apply this diff to add a trailing newline:
bootlogo=false +
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
config/boards/luckfox-lyra-plus.csc(1 hunks)config/bootenv/rk3506.txt(1 hunks)config/bootscripts/boot-rk3506.cmd(1 hunks)config/sources/families/rockchip.conf(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-10-26T10:41:35.118Z
Learnt from: HackingGate
PR: armbian/build#8665
File: config/boards/photonicat2.csc:4-4
Timestamp: 2025-10-26T10:41:35.118Z
Learning: In the Armbian build system, rk3576 boards consistently use BOARDFAMILY="rk35xx" for both vendor and edge kernel targets. The rk35xx family configuration sources rockchip64_common.inc, which provides edge and current kernel branch definitions, making these branches available even though they're not defined directly in rk35xx.conf.
Applied to files:
config/sources/families/rockchip.confconfig/boards/luckfox-lyra-plus.csc
📚 Learning: 2025-09-14T06:32:29.806Z
Learnt from: amazingfate
PR: armbian/build#8619
File: config/sources/families/rockchip.conf:222-230
Timestamp: 2025-09-14T06:32:29.806Z
Learning: In the Armbian build system, the write_uboot_platform() function implementations follow different patterns across Rockchip family files. The newer standard (used in rockchip64_common.inc and rk3506) includes 'status=none' parameter in dd commands, while older implementations (rk3288, rk322x) use an older pattern without this parameter. The rk3506 implementation correctly follows the current Rockchip family standard.
Applied to files:
config/sources/families/rockchip.conf
🪛 LanguageTool
config/bootenv/rk3506.txt
[grammar] ~3-~3: Dit kan een fout zijn.
Context: ...xtraargs=coherent_pool=4M bootlogo=false
(QB_NEW_NL)
🔇 Additional comments (6)
config/bootenv/rk3506.txt (1)
2-2: Verify coherent_pool size for 128MB device.The
coherent_pool=4Msetting allocates approximately 3% of the total 128MB RAM for DMA coherent memory. While this may be appropriate, please verify that this allocation doesn't constrain the system too much, especially given the low-memory profile of this board. Consider testing with different values if boot or runtime issues arise.config/bootscripts/boot-rk3506.cmd (1)
7-7: Memory address layout looks reasonable for 128MB device.The
ramdisk_addr_rat 0x02800000 (42MB) provides adequate spacing fromload_addrat 0x2000000 (32MB) and should work well for a device with 128MB total RAM. The address is properly used in the load command (line 47) and bootz command (line 80).If you encounter memory-related boot issues, consider verifying the complete memory map to ensure kernel, ramdisk, and DTB don't overlap:
- kernel_addr_r (inherited from u-boot environment)
- ramdisk_addr_r = 0x02800000 (42MB)
- fdt_addr_r (inherited from u-boot environment)
- load_addr = 0x2000000 (32MB)
config/sources/families/rockchip.conf (2)
17-17: Good use of parameter expansion for overridable default.The change to
SERIALCON=${SERIALCON:="ttyS2"}correctly provides a default value while allowing board configurations to override it. This works well with the new Luckfox Lyra Plus board that setsSERIALCON="ttyFIQ0"in its board config.
51-51: Boot environment file correctly points to new RK3506-specific config.The change to
BOOTENV_FILE='rk3506.txt'properly references the new boot environment file created in this PR with RK3506-specific settings (coherent_pool=4M, etc.). This separation from the generic rockchip.txt is appropriate for the distinct requirements of the RK3506 SoC.config/boards/luckfox-lyra-plus.csc (2)
1-13: Configuration looks good overall.The board configuration properly sets up the RK3506G2 with appropriate settings:
SERIALCON="ttyFIQ0"correctly overrides the family default for this board's serial consoleBOOT_SOC="rk3506"properly selects the RK3506 boot configurationDDR_BLOBand other boot parameters are appropriately specified
2-2: Clarify board name discrepancy.The PR title mentions "Luckfox Lyra Zero W" but the board configuration specifies
BOARD_NAME="Luckfox Lyra Plus". Please verify which is the correct name for this board to ensure consistency between the PR description and the actual configuration.
b066e02 to
3c6ba23
Compare
|
✅ This PR has been reviewed and approved — all set for merge! |
Description
Add new RK3506 CSC board "Luckfox Lyra Plus".
Additionally, tweaks RK3506 BOOT_SOC-specific settings to allow RK3506g2 to boot. (Else fails with memory allocation issues)
Depends on:
Relates to:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
./compile.sh BOARD=luckfox-lyra-plus BRANCH=vendor KERNEL_CONFIGURE=no DEB_COMPRESS=xz KERNEL_BTF=yes INSTALL_ARMBIAN_FIRMWARE=yes BUILD_DESKTOP=no BUILD_MINIMAL=yes RELEASE=trixieChecklist: