fix(Core/Vmaps): Fix inconsistency of hitInstance and hitModel to cause wrong area ids

[PkllonG]

TrinityCore/TrinityCore#28632
TrinityCore/TrinityCore@b4d6ca2
TrinityCore/TrinityCore@5eed750
TrinityCore/TrinityCore@c0d8dba
Co-Authored-By: ModoX [email protected]
Co-Authored-By: Shauren [email protected]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

• Closes

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• [ ✔ ] Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[PkllonG]

@TheSCREWEDSoftware Can the label be changed?

[TheSCREWEDSoftware]

Labels are automatically, I can add to be reviewd and to be tested after.

[TheSCREWEDSoftware]

But please check the current PR #22506 that's open in the case it affects with this one.

CC @walkline and @Grimdhex (was this cherry picks you wwanted to bring from tc?)

Edit: Does this require re-extraction?

[PkllonG]

But please check the current PR #22506 that's open in the case it affects with this one.

CC @walkline and @Grimdhex (was this cherry picks you wwanted to bring from tc?)

Edit: Does this require re-extraction?

No need to extract the maps.
This PR is unrelated to the PR you mentioned and does not affect each other.

[Grimdhex]

But please check the current PR #22506 that's open in the case it affects with this one.

CC @walkline and @Grimdhex (was this cherry picks you wanted to bring from tc?)

Edit: Does this require re-extraction?

Yes it was these PRs (faster than me x) ) but 2 commits are missing:

• TrinityCore/TrinityCore@18200e1
• TrinityCore/TrinityCore@cfb0f9f#diff-750113151af7fb57a6482da8516abb3a8c1e7c0bac50bf695de9934aa221ba3a

I've investigated the current state of vmaps these two last day. I can take a look and give a review if needed.

[PkllonG]

But please check the current PR #22506 that's open in the case it affects with this one.
CC @walkline and @Grimdhex (was this cherry picks you wanted to bring from tc?)
Edit: Does this require re-extraction?

Yes it was these PRs (faster than me x) ) but 2 commits are missing:

• TrinityCore/TrinityCore@18200e1
• TrinityCore/TrinityCore@cfb0f9f#diff-750113151af7fb57a6482da8516abb3a8c1e7c0bac50bf695de9934aa221ba3a

I've investigated the current state of vmaps these two last day. I can take a look and give a review if needed.

TrinityCore/TrinityCore@18200e1
The remaining PR has some code differences. Since the code in this PR has been tested by me and no errors were found, let's complete it in another PR.

[PkllonG]

[ ✔ ] Tested in-game by the author.

[Grimdhex]

Everything looks good in the porting except that you forgot to drop MAP_ALL_LIQUIDS at some place (mainly scripts). You can look my branch: Grimdhex@e12a11a I've maybe miss some of them but unsure.

No longer fill requireAllLiquids allows you to force the loading of VMaps info based on from LiquidType.dbc where you can't be sure of the liquid type.

[PkllonG]

Everything looks good in the porting except that you forgot to drop MAP_ALL_LIQUIDS at some place (mainly scripts). You can look my branch: Grimdhex@e12a11a I've maybe miss some of them but unsure.

No longer fill requireAllLiquids allows you to force the loading of VMaps info based on from LiquidType.dbc where you can't be sure of the liquid type.

I understand, I will implement it immediately, thank you very much.

[PkllonG]

@Grimdhex Am I doing this right?

[PkllonG]

[ ✔ ] Tested in-game by the author.

[Seamthesis]

I also test this PR and I didn't find no particular issue.

• Lich King platorm
• Several instance (Black temple, Molten core, Gundrak, Ulduar...)
• Test with tram
• Several mobs path test (around tree, water...)
• Test some spell (Jump, Blink...)

[PkllonG]

I also test this PR and I didn't find no particular issue.

• Lich King platorm
• Several instance (Black temple, Molten core, Gundrak, Ulduar...)
• Test with tram
• Several mobs path test (around tree, water...)
• Test some spell (Jump, Blink...)

Thank you

[biship]

It's been running on my server all day. No issues to report yet. Anything specific to be testing?

[biship]

It's been running on my server for 2 weeks. No issues to report yet.