Skip to content

Conversation

@TheSCREWEDSoftware
Copy link
Contributor

Ritual Torch from 96.1% to 100%
Orb of Returning from 99.8% to 85%

Also Ritual Torch now only drops people welding the quest, I have not validated it, but you only can get these Satchel by having the same quest. The important part this fixes the CHANCE of a shamna player not getting the ritual torch.

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

  • Closes N/A

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.
  • No tested just ran the SQL with no errors

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added the DB related to the SQL database label Nov 9, 2025
@Nyeriah
Copy link
Member

Nyeriah commented Nov 9, 2025

I think the chance should be 0 and they should have different loot ids so both of them drop always. Whoever wrote this originally probably just copy pasted it off wowhead which we know can't be taken blindly when it comes to loot, or anything else really

@TheSCREWEDSoftware
Copy link
Contributor Author

When I get back to the pc I can re-check this, I would check mop but takes to long to level a dreanei.

The torch should be 100% (or 0 for the same result) the org looking at wowhead tbc, mop, cata or wrath it's 84-85 so is not always gurantee i will assume

@TheSCREWEDSoftware
Copy link
Contributor Author

@Nyeriah

image

This is how it looks with the PR. 100% the quest item and 85% the orb of teleportation

@TheSCREWEDSoftware
Copy link
Contributor Author

I can't valid it this on officially servers as the torch doesn't drop on retail or mop, watching videos from tbc it seems they 100% gained from the bag, they are set 0 now, not grouped so they are 100% if not mistaken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DB related to the SQL database Ready to be Reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants