fix(DB/Conditions): update quest conditions to drop chokers

[sogladev]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

• Closes [Q - Zul'Drak] Quest item Unliving Choker not dropping as intended chromiecraft/chromiecraft#8446

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

ac: https://wowgaming.altervista.org/aowow/?npc=28519#drops

https://www.wowhead.com/wotlk/item=38660/unliving-choker#comments

https://www.wowhead.com/wotlk/item=38673/writhing-choker#comments

Precisely. All of the objectives and rewards for both chains are equal; the difference is in whether you did the chain from Grizzly Hills through to Drak'Tharon Keep prior to begining this chain. If yes, you get the Writhing Choker and its chain; if not, you get the Unliving Choker. You can never have both.

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

withered troll
.npc add temp 28519
unliving choker
.add 38660
invitation
.quest reward 12631
cleansing
.quest add 12238
.quest complete 12238
.quest reward 12238

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

On a fresh character, kill Withered Troll and see if a choker drops

The choker will either be Unliving or Writhing depending if the player has completed the Cleansing Drak'Tharon quest.

Once an Unliving choker or its quest has been done, Writhing should no longer drop

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.