-
-
Notifications
You must be signed in to change notification settings - Fork 69
Clean up macros #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Clean up macros #337
Conversation
Sync with original repo
|
The presubmit checks fail because the tests still rely on the original macros. |
|
I think in overhauling the testing infrastructure, I will rewrite the paland tests without copying them, so all of this will live in one repo without having to tiptoe around the incompatible licenses. This is a good PR, thanks for doing it; I'll copy it over into a new PR that I do and link to this one, so that I can do the paland fixup. |
|
Implemented in #339 |
|
Regarding paland, maybe you want to rewrite a similar test suite, or maybe you might use some or all of the "exhaustive testing" and/or "fuzz testing" I've proposed here: #343. |
This changes some
NANOPRINTFmacros toNPF, so that now a macro is a user-customizable option iff it is aNANOPRINTFone, whereas all theNPFones are for private use (or guards). Of course, functions/types/etc. are still prefixed withnpf.