-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add package diffpy.srxconfutils #31402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add package diffpy.srxconfutils #31402
Conversation
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/diffpy.srxconfutils/meta.yaml:
For recipes/diffpy.srxconfutils/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19120818667. Examine the logs at this URL for more detail. |
|
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/diffpy.srxconfutils/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19121765541. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@sbillinge @zmx27 It needs the consent that to be the maintainer here. |
|
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19127152483. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
sbillinge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see comments
|
|
||
| about: | ||
| home: https://github.com/diffpy.srxconfutils/diffpy.srxconfutils/ | ||
| summary: Configuration utilities for project. Part of xPDFsuite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "used in diffpy.xpdsuite and a link to the website where this is described. Not hte github which is private but somewhere on diffpy.org
| license_family: BSD | ||
| license_file: LICENSE.rst | ||
| description: | | ||
| This is a utility Python package for doing science. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should describe the package. This looks like some template text.
|
I agree to act as maintainer for this package |
|
@stevenhua0320 to get this to pass we will have to fix the toml in the package itself and re-release a patch bump to pypi. Let's work on that as well. |
I think the package toml right now is in good shape as it could be built successfully on three platforms after adding the entry point. The only one that is failing is that we let Zhiming @zmx27 to consent to be the maintainer. |
|
@zmx27 please can you post a comment on the PR saying you agree to be listed as a maintainer? Thanks. |
|
@conda-forge-admin, please rerender |
|
I agree to act as maintainer for this package. |
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
@conda-forge/help-python Hello Team, ready for review! |
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).