Skip to content

Conversation

@stevenhua0320
Copy link
Contributor

@stevenhua0320 stevenhua0320 commented Nov 6, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@stevenhua0320 stevenhua0320 changed the title Commiting recipe for conda-forge release of diffpy.srxconfutils Add package diffpy.srxconfutils Nov 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 6, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srxconfutils/meta.yaml) and found some lint.

Here's what I've got...

For recipes/diffpy.srxconfutils/meta.yaml:

  • ❌ The home item is expected in the about section.
  • ❌ The license item is expected in the about section.
  • ❌ The summary item is expected in the about section.
  • ❌ The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
  • ❌ The recipe must have some tests.
  • ❌ There are too few lines. There should be one empty line at the end of the file.
  • ❌ noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >={{ python_min }} in the run section of your recipe. You may also want to check the upstream source for the package's Python compatibility.

For recipes/diffpy.srxconfutils/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the run section of the recipe, you should usually use the pin python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use the pin python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19120818667. Examine the logs at this URL for more detail.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/diffpy.srxconfutils/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: zmx27. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srxconfutils/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srxconfutils/meta.yaml) and found some lint.

Here's what I've got...

For recipes/diffpy.srxconfutils/meta.yaml:

  • ❌ Non noarch packages should have python requirement without any version constraints.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19121765541. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srxconfutils/meta.yaml) and found it was in an excellent condition.

@stevenhua0320
Copy link
Contributor Author

@sbillinge @zmx27 It needs the consent that to be the maintainer here.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 6, 2025

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19127152483. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srxconfutils/meta.yaml) and found it was in an excellent condition.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments


about:
home: https://github.com/diffpy.srxconfutils/diffpy.srxconfutils/
summary: Configuration utilities for project. Part of xPDFsuite
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "used in diffpy.xpdsuite and a link to the website where this is described. Not hte github which is private but somewhere on diffpy.org

license_family: BSD
license_file: LICENSE.rst
description: |
This is a utility Python package for doing science.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should describe the package. This looks like some template text.

@sbillinge
Copy link
Contributor

I agree to act as maintainer for this package

@sbillinge
Copy link
Contributor

@stevenhua0320 to get this to pass we will have to fix the toml in the package itself and re-release a patch bump to pypi. Let's work on that as well.

@stevenhua0320
Copy link
Contributor Author

@stevenhua0320 to get this to pass we will have to fix the toml in the package itself and re-release a patch bump to pypi. Let's work on that as well.

I think the package toml right now is in good shape as it could be built successfully on three platforms after adding the entry point. The only one that is failing is that we let Zhiming @zmx27 to consent to be the maintainer.

@sbillinge
Copy link
Contributor

@zmx27 please can you post a comment on the PR saying you agree to be listed as a maintainer? Thanks.

@sbillinge
Copy link
Contributor

@conda-forge-admin, please rerender

@zmx27
Copy link

zmx27 commented Nov 6, 2025

I agree to act as maintainer for this package.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@stevenhua0320
Copy link
Contributor Author

@conda-forge/help-python Hello Team, ready for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants