-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add diffpy.srxplanargui #31426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add diffpy.srxplanargui #31426
Conversation
|
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/diffpy.srxplanargui/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19182594009. Examine the logs at this URL for more detail. |
|
@sbillinge @stevenhua0320 please confirm that you agree to be listed as maintainers |
|
I agree to be listed as maintainer. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| - codecov | ||
| - coverage | ||
| - pytest-cov | ||
| - pytest-env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add pip here.
|
@zmx27 You need to have |
| version: {{ version }} | ||
|
|
||
| source: | ||
| url: https://pypi.org/packages/source/d/diffpy_srxplanargui/diffpy_srxplanargui-1.0.0rc2.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to change it into https://pypi.org/packages/source/d/diffpy_srxplanargui/diffpy_srxplanargui-{{ version }}.tar.gz
|
I agree to be listed as maintainer |
|
@zmx27 Seems that these three dependencies are not installed correctly. |
| - pyface | ||
| - scipy | ||
| - traits | ||
| - pyfai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zmx27 add diffpy.srxplanar and traitsui here. I have made a PR on diffpy.srxplanargui too to fix this. We need Simon to do a fixed pre-release to fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, is chacoon conda-forge? From my memory I don't think we have it on conda-forge... and so is diffpy.srxplanar currently. But here I think we take all the packages that we list in requirements/conda.txt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chaco has to be pip installed. EVeything else is on conda-forge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If chaco is not on conda forge, how would we deal with the chaco dependency issue for the recipe? And it seems like srxplanar will only be on conda forge after we release that package to PyPI once srxconfutils is on CF, so we would simply have to wait?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will have to figure out how to allow pop installs during release because there are no plans for Chaco to go to conda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please could you raise an issue at skpkg
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
@zmx27 probably we need to wait to release |
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).