Skip to content

Conversation

@zmx27
Copy link

@zmx27 zmx27 commented Nov 7, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/diffpy.srxplanargui/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: sbillinge. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srxplanargui/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/diffpy.srxplanargui/meta.yaml:

  • ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19182594009. Examine the logs at this URL for more detail.

@zmx27
Copy link
Author

zmx27 commented Nov 7, 2025

@sbillinge @stevenhua0320 please confirm that you agree to be listed as maintainers

@stevenhua0320
Copy link
Contributor

I agree to be listed as maintainer.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srxplanargui/meta.yaml) and found it was in an excellent condition.

- codecov
- coverage
- pytest-cov
- pytest-env
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add pip here.

@stevenhua0320
Copy link
Contributor

@zmx27 You need to have pip in the test directory in the meta.yaml.

version: {{ version }}

source:
url: https://pypi.org/packages/source/d/diffpy_srxplanargui/diffpy_srxplanargui-1.0.0rc2.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to change it into https://pypi.org/packages/source/d/diffpy_srxplanargui/diffpy_srxplanargui-{{ version }}.tar.gz

@sbillinge
Copy link
Contributor

I agree to be listed as maintainer

@stevenhua0320
Copy link
Contributor

@zmx27 Seems that these three dependencies are not installed correctly.

diffpy-srxplanargui 1.0.0rc2 requires chaco, which is not installed.
diffpy-srxplanargui 1.0.0rc2 requires diffpy-srxplanar, which is not installed.
diffpy-srxplanargui 1.0.0rc2 requires traitsui, which is not installed.

- pyface
- scipy
- traits
- pyfai
Copy link
Contributor

@stevenhua0320 stevenhua0320 Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zmx27 add diffpy.srxplanar and traitsui here. I have made a PR on diffpy.srxplanargui too to fix this. We need Simon to do a fixed pre-release to fix this.

Copy link
Contributor

@stevenhua0320 stevenhua0320 Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, is chacoon conda-forge? From my memory I don't think we have it on conda-forge... and so is diffpy.srxplanar currently. But here I think we take all the packages that we list in requirements/conda.txt.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chaco has to be pip installed. EVeything else is on conda-forge

Copy link
Author

@zmx27 zmx27 Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If chaco is not on conda forge, how would we deal with the chaco dependency issue for the recipe? And it seems like srxplanar will only be on conda forge after we release that package to PyPI once srxconfutils is on CF, so we would simply have to wait?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will have to figure out how to allow pop installs during release because there are no plans for Chaco to go to conda

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you raise an issue at skpkg

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@stevenhua0320
Copy link
Contributor

@zmx27 probably we need to wait to releasediffpy.srxplanar on conda-forge first so that this staged-recipe could pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants