✨ Append the Recent Searches history #789
Conversation
|
That's cool:) |
| private var _binding: FragmentSearchBinding? = null | ||
| private val binding get() = _binding!! | ||
| private val viewModel: SearchPagerViewModel by viewModels() | ||
| private var recentSearchesFragment: RecentSearchesFragment? = null |
There was a problem hiding this comment.
i think it would be nicer to have a recyclerview adapter on each search fragment that contains the recent search items so that you could just swap the adapter to show recent searches instead of having to deal with this fragment here
There was a problem hiding this comment.
on each search fragment
I don't understand what you mean there. Are you referring to StreamSearchFragment, VideoSearchFragment, etc.?
There was a problem hiding this comment.
But the RecentSearches would only need to be related to the SearchPager. I don’t see what connection it would have with the fragments of the results.
I think we are thinking about different implementations.
Screen_recording_20251107_064804.mp4
There was a problem hiding this comment.
the recyclerview could show the recent searches instead of the search results when the search text box is empty
There was a problem hiding this comment.
I think I understand what you're saying: it's about placing the recent search items in the same RecyclerView and not creating a new fragment, right?
3 participants
I leave the request in case we want to discuss whether to add the option or not.