This repository was archived by the owner on Nov 7, 2025. It is now read-only.
test: Fix intermittent teardown failures in bats test #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## The Issue Automated tests were failing intermittently during teardown with `rm -rf` errors, even though the command should force removal. The failures were unpredictable and occurred in GitHub Actions CI. ## How This Solves The Issue - Removed `set -eu -o pipefail` from teardown() to prevent errors from causing teardown to fail - Added `|| true` to both `ddev delete` and `rm -rf` commands to make cleanup best-effort - Teardown failures are now non-fatal since cleanup is cosmetic on ephemeral CI infrastructure (the VM gets destroyed anyway) - Uniquely named test directories prevent interference between tests even if cleanup fails ## Automated Testing Overview The existing test suite validates this change. Tests will no longer fail due to teardown cleanup issues. ## Release/Deployment Notes This is a test infrastructure change only. No impact on add-on functionality or user-facing features. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Automated tests were failing intermittently during teardown with
rm -rferrors, even though the command should force removal. The failures were unpredictable and occurred in GitHub Actions CI.Example: https://github.com/ddev/ddev-php85/actions/runs/18613287473/job/53074416697#step:2:195
How This Solves The Issue
set -eu -o pipefailfrom teardown() to prevent errors from causing teardown to fail|| trueto bothddev deleteandrm -rfcommands to make cleanup best-effortAutomated Testing Overview
The existing test suite validates this change. Tests shouldn't fail due to teardown cleanup issues.