fix: Remove PLATFORM_RELATIONSHIPS to fix upsun CLI confusion, fixes #13, fixes #15 #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
, fixes #15 * #13 * #15 PLATFORM_RELATIONSHIPS caused two major problems: 1. The `upsun` CLI detected it and behaved as if running in production, causing `ddev pull upsun` to fail with empty database dumps (#13) 2. PLATFORM_RELATIONSHIPS was incomplete, missing opensearch and memcached services (#15) Removed PLATFORM_RELATIONSHIPS entirely from generated environment variables because: - Applications don't actually need it - they use simpler env vars (MARIADB_HOST, DB_HOST, etc.) - The .environment file already maps service variables to application-expected variables - It confuses the upsun CLI into production mode - Building a complete PLATFORM_RELATIONSHIPS is complex and unnecessary Changes: - PlatformEnvironmentGenerator.php: Removed PLATFORM_RELATIONSHIPS from generatePlatformVariables() - common-assertions.bash: Removed test that verified PLATFORM_RELATIONSHIPS structure - Added explanatory comments linking to issue #13 This is a breaking change only if applications were directly reading PLATFORM_RELATIONSHIPS. Applications should use the simpler environment variables instead: - Database: MARIADB_HOST, MYSQL_HOST, POSTGRES_HOST, or DB_HOST - Redis: REDIS_HOST, CACHE_HOST - Services: Mapped via .environment file 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
ddev pull upsun(no database) #13PLATFORM_RELATIONSHIPS caused two major problems:
upsunCLI detected it and behaved as if running in production, causingddev pull upsunto fail with empty database dumps (ddev-upsun doesn't work withddev pull upsun(no database) #13)Removed PLATFORM_RELATIONSHIPS entirely from generated environment variables because:
Changes:
ddev pull upsun(no database) #13This is a breaking change only if applications were directly reading PLATFORM_RELATIONSHIPS. Applications should use the simpler environment variables instead:
🤖 Generated with Claude Code