Add serialize_fn attribute to Insertable derive macro
#3837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p4r4d0xb0x
reviewed
Oct 25, 2023
p4r4d0xb0x
left a comment
p4r4d0xb0x
left a comment
There was a problem hiding this comment.
i think it can provide support enums to mysql !
souunds good
how about other reviewers..?
AlexStorm1313
approved these changes
Oct 25, 2023
Member
Isn't there some form of support for this via https://crates.io/crates/diesel-derive-enum ? |
weiznich
reviewed
Oct 26, 2023
Member
weiznich
left a comment
weiznich
left a comment
There was a problem hiding this comment.
Thanks for submitting this PR 👍 The implementation itself looks fine for me and I'm open this feature.
The PR is currently missing:
- Some more tests
- Documentation for the new feature
Additionally I would like to keep the functionality for serialize and deserialize similar, that means we should add an
- Implementation for
AsChangesetto keep that attribute compatible there as well - A corresponding implementation for deserializing to keep the functionality somewhat symmetrical
| "`#[diesel(embed)]` cannot be combined with `#[diesel(serialize_as)]`", | ||
| )); | ||
| } | ||
| (None, Some(AttributeSpanWrapper { attribute_span, .. }), true) => { |
Member
There was a problem hiding this comment.
We want to have a compile_fail test for this cases.
Member
|
The code looks okay to me.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3836.
I would be happy to get some feedback about the implementation. I would write documentation if you are fine with the implementation as it is. I can also add more tests if needed.