refactor: add missing 'new' and exception handling #1344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bokyeom <[email protected]>
k-kbk
force-pushed
the
add-exception-handling
branch
2 times, most recently
from
1dbd05b to
eff94d9
Compare
Signed-off-by: k-kbk <[email protected]>
k-kbk
force-pushed
the
add-exception-handling
branch
2 times, most recently
from
9749bec to
e54c2c0
Compare
crazy-max
requested changes
Apr 7, 2025
k-kbk
force-pushed
the
add-exception-handling
branch
from
e54c2c0 to
8ea72f7
Compare
Contributor
Author
|
@crazy-max Sure! I deleted it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.rmSync(...)that throw an exception on failure are recommended to be wrapped in try/catch.newto create an object is the standard and safe way to do it.