Fix bad jump from yield break inside catch in async-iterator

[jcouv]

Fixes #79124

The problem is that given the following code:

       try
       {
           try
           {
               Write("Break ");
               yield break;
           }
           finally
           {
               Write("Throw ");
               throw null;
           }
       }
       catch
       {
           Write("Caught ");
           yield break;
       }
       finally
       {
           Write("Finally ");
       }

We'd lower to a tree like this (output from DumpSource() with some formatting/cleanups):

       // ...
       try
       {
           // ...
           <finallyEntry-41>: ;
       }
       catch ( NULL)
       {
           Write("Caught ");
           this.<>w__disposeMode = True;
           goto <finallyEntry-41>; // Wrong place to go to
       }
       finally
       {
           if (!temp1 IntEqual -1) goto <afterif-45>;
           {
               Write("Finally ");
           }
           <afterif-45>: ;
       }

       if (!this.<>w__disposeMode) 
           goto <afterif-46>;

       goto <exprReturn-33>;
       <afterif-46>: ;

The fix is to move the label after the try (output from DumpSource()):

           try
           {
                   try
                   {
                       Write("Break ");

                       this.<>w__disposeMode = True;
                       goto <finallyEntry-36>;
                   }
                   finally
                   {
                       if (!temp1 IntEqual -1) goto <afterif-37>;

                       Write("Throw ");
                       throw null;

                       <afterif-37>: ;
                   }
                   <finallyEntry-36>: ;
                   
                   if (!this.<>w__disposeMode) goto <afterif-38>;

                   goto <finallyEntry-35>;
                   <afterif-38>: ;
           }
           catch ( NULL)
           {
               Write("Caught ");

               this.<>w__disposeMode = True;
               goto <finallyEntry-35>;
           }
           finally
           {
               if (!temp1 IntEqual -1) goto <afterif-39>;

               Write("Finally ");
               <afterif-39>: ;
           }

           <finallyEntry-35>: ; // label is moved after the `try`
       }

       if (!this.<>w__disposeMode) goto <afterif-40>;
       goto <exprReturn-27>;
       <afterif-40>: ;

[AlekseyTs]

_currentDisposalLabel = tryEnd;

According to documentation for _currentDisposalLabel: " Inside a try or catch with a finally, we'll use the label directly preceding the finally." This is no longer accurate. Please adjust documentation accordingly, perhaps also explaining why placing the label there gives us the right control flow. #Closed

[AlekseyTs]

tryEnd

I think the name is somewhat unclear or open to interpretation. Consider renaming to "afterTryCatchFinallyStatement" #Closed

[AlekseyTs]

(if any)

It looks like we will never get here without a finally. #Closed

[AlekseyTs]

// Append a label at the end of the try, which disposal within try can jump to to execute the finally (if any):

Consider making the comment clearer. Something like: "Append a label immediately after the try-catch-finally statement, which disposal within try/catch blocks jumps to with a goal to pass control flow to the finally block" implicitly" #Closed

[AlekseyTs]

Done with review pass (commit 2) #Closed

[AlekseyTs]

LGTM (commit 3)