Add SDK analyzer assembly redirector #80969
Open
+279
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Internal for testing. | ||
| [SuppressMessage("RoslynDiagnosticsReliability", "RS0034: Exported parts should have a public constructor marked with 'ImportingConstructorAttribute'", | ||
| Justification = "This is an internal constructor exposed for testing and delegated to by the public importing constructor")] |
Member
There was a problem hiding this comment.
If we're not actually using the MEF component for testing, the better pattern might be to break the stuff needed for testing out to a separate class and then test that directly.
| [Obsolete(MefConstruction.ImportingConstructorMessage, error: true)] | ||
| public SdkAnalyzerAssemblyRedirector(SVsServiceProvider serviceProvider) : this( | ||
| Path.GetFullPath(Path.Combine(AppDomain.CurrentDomain.BaseDirectory, @"CommonExtensions\Microsoft\DotNet")), | ||
| serviceProvider.GetServiceOnMainThread<SVsActivityLog, IVsActivityLog>()) |
Member
There was a problem hiding this comment.
Eek this is a deadlock waiting to happen. Since this isn't cross-repo anymore, can we adjust the interface to follow VS threading rules? Especially since this just appears for logging, we could easily fetch it asynchronously and write out the log once we get the service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved here from the SDK per David Kean's request (to avoid another assembly load). Originally lived here:
Validation: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/684831