Support generating explicit Equals/GetHashCode for records #81124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Nov 10, 2025
| return obj is Program program && | ||
| b == program.b && | ||
| EqualityComparer<HashSet<string>>.Default.Equals(s, program.s); | ||
| } |
Member
Author
There was a problem hiding this comment.
View with whitespace off.
dibarbet
approved these changes
Nov 10, 2025
| { | ||
| int a; | ||
| public virtual bool Equals(Program program) |
Member
There was a problem hiding this comment.
question - should this be generated as Program?
jasonmalinowski
approved these changes
Nov 10, 2025
|
|
||
| return CreateEqualsMethod( | ||
| compilation, | ||
| modifiers: isRecord ? containingType.IsSealed ? DeclarationModifiers.None : DeclarationModifiers.Virtual : null, |
Member
There was a problem hiding this comment.
Is it easier just to have the 'null' case be explicitly passing Overrides rather than defaulting it in the method? Looks like there's only two use sites...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.