fix: new terminals will be created in the panel of the clicked button #16538
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Previously, clicking the "Add Terminal" button in the bottom panel would always create a terminal widget in the bottom panel of the "current terminal".
Now, clicking the "Add Terminal" button in a bottom panel will create a terminal widget in the same bottom panel, even when the "current terminal" is in another bottom panel.
Fixes #16527
How to test
Follow-ups
In the function
splitTerminal(line 1003) ofterminal-frontend-contribution.ts, the result of thewithWidgetcall is checked using the||operator instead of an explicit=== falsecomparison.Since
withWidgetreturns a value of typeT | false, using=== falsewould make the condition clearer and more type-safe.Breaking changes
Review checklist
Reminder for reviewers