fix(plugin-vite): merge Vite build.lib config
#3721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caoxiemeihao
force-pushed
the
fix/plugin-vite-merge
branch
2 times, most recently
from
edd59b6 to
e8e226d
Compare
|
When will this pr be merged and released in the next version? |
BlackHole1
approved these changes
Nov 8, 2024
BlackHole1
force-pushed
the
fix/plugin-vite-merge
branch
from
e8e226d to
10624d1
Compare
Member
|
PTAL @electron/forgers |
|
Why this PR is not merging? It works perfectly... |
VerteDinde
approved these changes
Nov 20, 2024
|
this lets us bundle to esm not cjs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Closes #3715