Delete further remnants from KAT_RUN_MODE=local #4875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#4863 removed the gold-file machinery (
KAT_RUN_MODE=local), but the Make targets are still overly verbose, still having the-envoyspecifier that was originally added to have-envoy(non-gold) and-local(gold) names. This drops that-envoybit, but this will require a minor sibling change in apro.git to match.Related Issues
(none)
Testing
(none)
Checklist
Does my change need to be backported to a previous release? - no
I made sure to update
CHANGELOG.md. - no applicable changesRemember, the CHANGELOG needs to mention:
This is unlikely to impact how Ambassador performs at scale. - not a runtime change
Remember, things that might have an impact at scale include:
My change is adequately tested. - I'd say so
Remember when considering testing:
I updated
DEVELOPING.mdwith any any special dev tricks I had to use to work on this code efficiently. - no tricksnThe changes in this PR have been reviewed for security concerns and adherence to security best practices.