Skip to content

Conversation

@zencircle
Copy link
Contributor

@zencircle zencircle commented May 1, 2025

Fix the permission version 3.10.0 E0430 18:21:29.962315 1 reflector.go:166] "Unhandled Error" err="pkg/kates/client.go:469: Failed to watch *unstructured.Unstructured: can't watch endpointslices.v1.discovery.k8s.io: forbidden" logger="UnhandledError"

Description

fix the permission of the role emissary-ingress

Related Issues

List related issues.

Testing

manual tets

Checklist

  • Does my change need to be backported to a previous release?

    • What backport versions were discussed with the Maintainers in the Issue?
  • I made sure to update CHANGELOG.md.

    Remember, the CHANGELOG needs to mention:

    • Any new features
    • Any changes to our included version of Envoy
    • Any non-backward-compatible changes
    • Any deprecations
  • This is unlikely to impact how Ambassador performs at scale.

    Remember, things that might have an impact at scale include:

    • Any significant changes in memory use that might require adjusting the memory limits
    • Any significant changes in CPU use that might require adjusting the CPU limits
    • Anything that might change how many replicas users should use
    • Changes that impact data-plane latency/scalability
  • My change is adequately tested.

    Remember when considering testing:

    • Your change needs to be specifically covered by tests.
      • Tests need to cover all the states where your change is relevant: for example, if you add a behavior that can be enabled or disabled, you'll need tests that cover the enabled case and tests that cover the disabled case. It's not sufficient just to test with the behavior enabled.
    • You also need to make sure that the entire area being changed has adequate test coverage.
      • If existing tests don't actually cover the entire area being changed, add tests.
      • This applies even for aspects of the area that you're not changing – check the test coverage, and improve it if needed!
    • We should lean on the bulk of code being covered by unit tests, but...
    • ... an end-to-end test should cover the integration points
  • I updated CONTRIBUTING.md with any special dev tricks I had to use to work on this code efficiently.

  • The changes in this PR have been reviewed for security concerns and adherence to security best practices.

Fix the permission version 3.10.0 ``E0430 18:21:29.962315       1 reflector.go:166] "Unhandled Error" err="pkg/kates/client.go:469: Failed to watch *unstructured.Unstructured: can't watch endpointslices.v1.discovery.k8s.io: forbidden" logger="UnhandledError"``
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. t:bug Something isn't working labels May 1, 2025
- secrets
- configmaps
- endpoints
- endpointslices

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed the same error

endpointslices are part of a different API group so a new rule is needed:

- apiGroups:
  - discovery.k8s.io
  resources:
  - endpointslices
  verbs:
  - get
  - list
  - watch

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zencircle I think this may have flown under your radar. Could you make the suggested change please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files. t:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants