Redirect werl to erl.exe on windows ps templates, fix CI #956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since OTP-26, which is now our earlier major version supported, werl.exe just no longer really exists and we use erl.exe instead. The other windows template file does dynamic matching but ps stuff is a bit more complex and I no longer have a windows computer to test this on, so I'm going for the safest fix at the time. Addresses erlware#955
Collaborator
Author
|
Not quite sure for the windows errors. The dialyzer errors appear to be an OTP spec issue:
Would need to open an OTP PR and drop dialyzer from the CI temporarily. |
Collaborator
Author
|
hah, got it, the failures are that the wintest fails since we're using a rebar3 structure that vendors relx and the _checkout trick isn't working. |
ferd
force-pushed
the
remove-werl-refs-in-windows_ps
branch
2 times, most recently
from
d1e776c to
41c3579
Compare
ferd
changed the title
ferd
force-pushed
the
remove-werl-refs-in-windows_ps
branch
2 times, most recently
from
88a8da9 to
46beb83
Compare
ferd
force-pushed
the
remove-werl-refs-in-windows_ps
branch
12 times, most recently
from
eda16c1 to
a6b1b5b
Compare
tsloughter
approved these changes
Aug 11, 2025
ferd
force-pushed
the
remove-werl-refs-in-windows_ps
branch
from
a6b1b5b to
fceda1d
Compare
Collaborator
Author
|
Finally some debugging progress: The node is running, but can't be pinged. It should be slightly easier to debug network config stuff than service registration as someone without a windows computer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since OTP-26, which is now our earlier major version supported, werl.exe just no longer really exists and we use erl.exe instead. The other windows template file does dynamic matching but ps stuff is a bit more complex and I no longer have a windows computer to test this on, so I'm going for the safest fix at the time.
Addresses #955