-
Notifications
You must be signed in to change notification settings - Fork 10.2k
tests: Add make-mirror test implementation #20908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
tests: Add make-mirror test implementation #20908
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ronaldngounou The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8ee90f8 to
d97e51b
Compare
- Implement mirror test structure
- Add test/common functionality
- Create ctl_v3_make_mirror_test
Signed-off-by: Ronald Ngounou <[email protected]>
Signed-off-by: ronaldngounou <[email protected]>
d97e51b to
983fee2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 21 files with indirect coverage changes @@ Coverage Diff @@
## main #20908 +/- ##
==========================================
- Coverage 69.21% 69.20% -0.01%
==========================================
Files 422 422
Lines 34831 34839 +8
==========================================
+ Hits 24108 24112 +4
+ Misses 9327 9326 -1
- Partials 1396 1401 +5 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@ronaldngounou: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Context
This PR contributes to #20612 . The goal is to migrate tests/e2e/ctl_v3_make_mirror_test.go to the common testing framework
co-author: @yagikota
While we were able to migrate the e2e tests, we would like to have a discussion with the maintenairs on how we can migrate the integration tests as providing guidance would require more context about the source code.
Testing