Skip to content

Conversation

@ronaldngounou
Copy link
Member

@ronaldngounou ronaldngounou commented Nov 8, 2025

Context

This PR contributes to #20612 . The goal is to migrate tests/e2e/ctl_v3_make_mirror_test.go to the common testing framework

co-author: @yagikota

While we were able to migrate the e2e tests, we would like to have a discussion with the maintenairs on how we can migrate the integration tests as providing guidance would require more context about the source code.

Testing

go test -v -count=1 -tags=e2e . -run TestMakeMirror

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ronaldngounou
Once this PR has been reviewed and has the lgtm label, please assign fuweid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

    - Implement mirror test structure
    - Add test/common functionality
    - Create ctl_v3_make_mirror_test

Signed-off-by: Ronald Ngounou <[email protected]>
Signed-off-by: ronaldngounou <[email protected]>
@ronaldngounou ronaldngounou force-pushed the ronald/ctl_v3_make_mirror_test_clean branch from d97e51b to 983fee2 Compare November 9, 2025 00:02
@codecov
Copy link

codecov bot commented Nov 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.20%. Comparing base (1b2ed5a) to head (983fee2).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

see 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20908      +/-   ##
==========================================
- Coverage   69.21%   69.20%   -0.01%     
==========================================
  Files         422      422              
  Lines       34831    34839       +8     
==========================================
+ Hits        24108    24112       +4     
+ Misses       9327     9326       -1     
- Partials     1396     1401       +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b2ed5a...983fee2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@k8s-ci-robot
Copy link

@ronaldngounou: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-unit-test-386 983fee2 link true /test pull-etcd-unit-test-386
pull-etcd-verify 983fee2 link true /test pull-etcd-verify
pull-etcd-unit-test-arm64 983fee2 link true /test pull-etcd-unit-test-arm64
pull-etcd-unit-test-amd64 983fee2 link true /test pull-etcd-unit-test-amd64
pull-etcd-integration-2-cpu-arm64 983fee2 link true /test pull-etcd-integration-2-cpu-arm64
pull-etcd-integration-4-cpu-arm64 983fee2 link true /test pull-etcd-integration-4-cpu-arm64
pull-etcd-integration-1-cpu-arm64 983fee2 link true /test pull-etcd-integration-1-cpu-arm64
pull-etcd-integration-4-cpu-amd64 983fee2 link true /test pull-etcd-integration-4-cpu-amd64
pull-etcd-integration-2-cpu-amd64 983fee2 link true /test pull-etcd-integration-2-cpu-amd64
pull-etcd-integration-1-cpu-amd64 983fee2 link true /test pull-etcd-integration-1-cpu-amd64
pull-etcd-coverage-report 983fee2 link true /test pull-etcd-coverage-report
pull-etcd-e2e-amd64 983fee2 link true /test pull-etcd-e2e-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants