Skip to content

Conversation

@yaxit24
Copy link

@yaxit24 yaxit24 commented Jul 8, 2025

Fixes #356

Summary by Sourcery

Switch primary and title fonts to Open Sans, include its font files, update fallbacks to add Arial, and adjust button font weight

Enhancements:

  • Add @font-face declarations for Open Sans in regular, bold, italic, and bold italic styles
  • Replace primary and title font-family variables with Open Sans and include Arial in the fallback stack
  • Adjust button font weight from 600 to 500

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 8, 2025

Reviewer's Guide

Adds Open Sans webfont declarations and updates global font settings to use Open Sans, including improved fallbacks and adjusted button weights.

File-Level Changes

Change Details Files
Added Open Sans @font-face declarations
  • Four new @font-face blocks for regular, bold, italic, and bold-italic variants
  • Sources specified in both WOFF2 and WOFF formats
  • font-display set to swap for all variants
src/pretalx/static/common/css/_fonts.css
Updated global font variables and button styling
  • Added Arial to fallback font list
  • Set --font-family and --font-family-title to Open Sans
  • Reduced font-weight on title buttons from 600 to 500
src/pretalx/static/common/css/_fonts.css

Possibly linked issues

  • #356: The PR changes fonts in _fonts.css to 'Open Sans' to match eventyay-tickets as requested by the issue.
  • #356: The PR changes font weights and families in CSS to address the bold text issue in the left menu.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yaxit24 - I've reviewed your changes - here's some feedback:

  • You’re still including the Titillium Web @font-face definitions even though you switched --font-family-title to Open Sans—consider removing the unused Titillium Web blocks to slim down the CSS.
  • You set button font-weight to 500 but only imported weights 400 and 700—either import the 500 (semibold) font-face or pick one of the already-loaded weights to avoid synthetic font rendering.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- You’re still including the Titillium Web @font-face definitions even though you switched --font-family-title to Open Sans—consider removing the unused Titillium Web blocks to slim down the CSS.
- You set button font-weight to 500 but only imported weights 400 and 700—either import the 500 (semibold) font-face or pick one of the already-loaded weights to avoid synthetic font rendering.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@yaxit24
Copy link
Author

yaxit24 commented Jul 8, 2025

Screenshot 2025-07-08 at 1 34 37 PM Screenshot 2025-07-08 at 1 34 51 PM Screenshot 2025-07-08 at 1 35 15 PM

Copy link
Contributor

@Saksham-Sirohi Saksham-Sirohi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pull request shows a lot of changes @yaxit24

@mariobehling
Copy link
Member

Closing as we are now working on eventyay next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change fonts to match choices on eventyay-tickets

8 participants