-
Notifications
You must be signed in to change notification settings - Fork 95
Change fonts to match eventyay-tickets #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hopefully this one will work
…june-2025 Merge with upstream until middle of June 2025
…rest-of-june-2025 Merge from upstream until end of June 2025
Reviewer's GuideAdds Open Sans webfont declarations and updates global font settings to use Open Sans, including improved fallbacks and adjusted button weights. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @yaxit24 - I've reviewed your changes - here's some feedback:
- You’re still including the Titillium Web @font-face definitions even though you switched --font-family-title to Open Sans—consider removing the unused Titillium Web blocks to slim down the CSS.
- You set button font-weight to 500 but only imported weights 400 and 700—either import the 500 (semibold) font-face or pick one of the already-loaded weights to avoid synthetic font rendering.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- You’re still including the Titillium Web @font-face definitions even though you switched --font-family-title to Open Sans—consider removing the unused Titillium Web blocks to slim down the CSS.
- You set button font-weight to 500 but only imported weights 400 and 700—either import the 500 (semibold) font-face or pick one of the already-loaded weights to avoid synthetic font rendering.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pull request shows a lot of changes @yaxit24
|
Closing as we are now working on eventyay next. |



Fixes #356
Summary by Sourcery
Switch primary and title fonts to Open Sans, include its font files, update fallbacks to add Arial, and adjust button font weight
Enhancements: