Skip to content

Conversation

@Amitjoiya
Copy link

@Amitjoiya Amitjoiya commented Nov 3, 2025

fix(macOS): mark AppIcon as template-rendering-intent to enable system tinting

Summary by Sourcery

Enhancements:

  • Add "template-rendering-intent" attribute to the AppIcon asset in Contents.json to allow system tinting on macOS

Summary by Sourcery

Enable system tinting on macOS by marking the AppIcon asset as a template and harden the Windows build pipeline by stripping out a missing language include in the installer script

Enhancements:

  • Mark the macOS AppIcon asset as template-rendering-intent to enable system tinting

Build:

  • Remove references to a missing Icelandic language include from the Windows Inno Setup script to prevent CI build failures

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 3, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR refines the Windows CI installer step by stripping out a missing Icelandic language include to prevent build failures, and updates the macOS AppIcon asset to use template-rendering-intent so the system can apply tinting.

Entity relationship diagram for AppIcon asset Contents.json update

erDiagram
    APPICON {
      string filename
      string size
      string scale
      string template_rendering_intent
    }
    APPICONSET {
      string Contents_json
    }
    APPICONSET ||--o{ APPICON : contains
Loading

File-Level Changes

Change Details Files
Sanitize Inno Setup script to avoid missing language include
  • Added a conditional path check for inno-script.iss
  • Filtered out any lines matching 'Icelandic.isl'
  • Inserted this cleanup just before invoking iscc
.github/actions/windows/action.yml
Enable template rendering for macOS AppIcon asset
  • Added the "template-rendering-intent" attribute to Contents.json
  • Applied template rendering flags across all AppIcon entries
macos/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Amitjoiya Amitjoiya changed the title macOS: mark AppIcon as template-rendering-intent to enable system tin… fix(macOS): mark AppIcon as template-rendering-intent to enable system tinting Nov 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Build Status

Build successful. APKs to test: https://github.com/fossasia/pslab-app/actions/runs/19027011312/artifacts/4446130840.

Screenshots

Android Screenshots
iPhone Screenshots
iPad Screenshots

@Amitjoiya
Copy link
Author

Hi, all checks have passed successfully ✅
Please review and merge this pull request when possible.

@Amitjoiya Amitjoiya marked this pull request as draft November 4, 2025 05:56
@Amitjoiya Amitjoiya marked this pull request as ready for review November 4, 2025 05:56
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Amitjoiya
Copy link
Author

Originally made while preparing for GSoC, now also considered as my pre-contribution for GirlScript Summer of Code (GSSoC 2025).
This PR improves the project’s readability and aligns with open-source contribution standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant