Skip to content

Conversation

@ssiyad
Copy link
Member

@ssiyad ssiyad commented Nov 7, 2025

closes #3797

@ssiyad ssiyad changed the title fix(account)!: disallow temporary email providers fix(account)!: Disallow temporary email providers Nov 7, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 44.48%. Comparing base (3647dcd) to head (c6412e5).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...s/press/doctype/account_request/account_request.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3827      +/-   ##
===========================================
- Coverage    45.02%   44.48%   -0.55%     
===========================================
  Files          714      716       +2     
  Lines        48570    48620      +50     
===========================================
- Hits         21868    21627     -241     
- Misses       26702    26993     +291     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tanmoysrt
Copy link
Member

tanmoysrt commented Nov 8, 2025

@ssiyad Maybe we can use this disposable repo's domain list to filter out temp mails instead of maintaining the list ourselves.

There might be some library of it.

Secondly, maybe keep a feature flag at Press Settings to disable this ? Useful for any random purpose (development e.g.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restrict temporary emails from creating an account

3 participants