feat(forms): Add new configuration fields to forms destination - Request source #17662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrienClairembault
requested changes
Aug 9, 2024
phpunit/functional/Glpi/Form/Destination/CommonITILField/RequestSourceFieldTest.php
Outdated
Show resolved
Hide resolved
phpunit/functional/Glpi/Form/Destination/CommonITILField/RequestSourceFieldTest.php
Outdated
Show resolved
Hide resolved
phpunit/functional/Glpi/Form/Destination/CommonITILField/RequestSourceFieldTest.php
Outdated
Show resolved
Hide resolved
phpunit/functional/Glpi/Form/Destination/CommonITILField/RequestSourceFieldTest.php
Outdated
Show resolved
Hide resolved
phpunit/functional/Glpi/Form/Destination/CommonITILField/RequestSourceFieldTest.php
Outdated
Show resolved
Hide resolved
src/Glpi/Form/Destination/CommonITILField/RequestSourceFieldConfig.php
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/form/destination_config_fields/request_source.cy.js
Outdated
Show resolved
Hide resolved
AdrienClairembault
requested changes
Aug 23, 2024
phpunit/functional/Glpi/Form/Destination/CommonITILField/RequestSourceFieldTest.php
Outdated
Show resolved
Hide resolved
orthagh
changed the title
orthagh
changed the title
src/Glpi/Form/Destination/CommonITILField/RequestSourceField.php
Outdated
Show resolved
Hide resolved
AdrienClairembault
approved these changes
Sep 2, 2024
tests/cypress/e2e/form/destination_config_fields/request_source.cy.js
Outdated
Show resolved
Hide resolved
cedric-anne
requested changes
Sep 11, 2024
Member
cedric-anne
left a comment
cedric-anne
left a comment
There was a problem hiding this comment.
I wait for conflicts to be fixed before starting the complete review.
cedric-anne
reviewed
Sep 30, 2024
phpunit/functional/Glpi/Form/Destination/CommonITILField/RequestSourceFieldTest.php
Outdated
Show resolved
Hide resolved
cedric-anne
approved these changes
Sep 30, 2024
ccailly
reviewed
Sep 30, 2024
tests/cypress/e2e/form/destination_config_fields/request_source.cy.js
Outdated
Show resolved
Hide resolved
cedric-anne
force-pushed
the
feature/form-destination-config-fields-request-source
branch
from
f05dea8 to
47dab76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible configurations :
"Specific request source" display a secondary select to let the user pick the chosen source :